[Translator] Updated TranslationInterface import#14667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

NicolasJourdan wants to merge1 commit intosymfony:5.2fromNicolasJourdan:patch-1

Closed

[Translator] Updated TranslationInterface import#14667

NicolasJourdan wants to merge1 commit intosymfony:5.2fromNicolasJourdan:patch-1

Conversation

Copy link

Contributor

NicolasJourdan commentedDec 7, 2020

The current import is :Symfony\Contracts\Translation\TranslationInterface.

In this bloc, I think the needed import isSymfony\Component\Translation\TranslatorInterface

carsonbot added Status: Needs Review Translation labels

Dec 7, 2020

carsonbot changed the title~~[Translation] Updated TranslationInterface importation~~[Translator] [Translation] Updated TranslationInterface importation

Dec 7, 2020

NicolasJourdan changed the title~~[Translator] [Translation] Updated TranslationInterface importation~~[Translator] [Translation] Updated TranslationInterface import

Dec 7, 2020

Updated translation.rst

139c874

NicolasJourdan changed the title~~[Translator] [Translation] Updated TranslationInterface import~~[Translator] Updated TranslationInterface import

Dec 7, 2020

Copy link

Member

wouterj commentedDec 9, 2020

Hi@NicolasJourdan! Thanks for taking the time to submit a fix to the documentation.

Unfortunately, I believe this fix is incorrect. TheTranslatorInterface was moved from the components to the contracts namespace in Symfony 4.2 (refsymfony/symfony#28210). If you use the version switcher (in the top right corner) to switch to the 4.1 docs (or any docs before 4.2), you can see the components use statement is used:https://symfony.com/doc/4.1/translation#basic-translation