Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[RateLimiter] Add diagrams to better explain the differences#14436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@wouterj
Copy link
Member

This is just a POC to add some diagrams to better explain the differences in the rate limiter strategies.

OskarStark and javiereguiluz reacted with heart emojiOskarStark reacted with rocket emoji
@javiereguiluz
Copy link
Member

javiereguiluz commentedOct 17, 2020•
edited
Loading

I like them a lot! Good work!!

@wouterjwouterjforce-pushed theratelimiter/add-diagrams branch from9843b28 tocdf3b76CompareOctober 19, 2020 16:07
@OskarStark
Copy link
Contributor

IMO this should now target5.2

@javiereguiluz
Copy link
Member

These still look very nice to me. Wouter, do you plan to add some polish or do you think we can merge this? Thanks!

@wouterjwouterjforce-pushed theratelimiter/add-diagrams branch fromcdf3b76 to32df98dCompareJanuary 29, 2021 14:19
@wouterjwouterj marked this pull request as ready for reviewJanuary 29, 2021 14:19
@wouterj
Copy link
MemberAuthor

Sorry, I forgot about this one. I'm not 100% happy with the text (it seems a bit too verbose to me), but this should be ready for a review & merge.

@javiereguiluzjaviereguiluz added this to the5.2 milestoneJan 29, 2021
@javiereguiluzjaviereguiluz changed the base branch from5.x to5.2January 29, 2021 16:07
@javiereguiluz
Copy link
Member

Merged in 5.2 and up. Thanks Wouter!

@javiereguiluzjaviereguiluz merged commitb2b7d91 intosymfony:5.2Jan 29, 2021
@wouterjwouterj deleted the ratelimiter/add-diagrams branchJanuary 29, 2021 18:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

4 participants

@wouterj@javiereguiluz@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp