Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Routing & Inheritance#14430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:4.4fromsylfabre:messenger_override
Apr 7, 2021

Conversation

@sylfabre
Copy link
Contributor

This PR details how Messenger deals with messages and inheritance.

We were discussing with my colleagues and had to do a quick POC to find out as it is not documented, and we had some doubt about it.

@sylfabre
Copy link
ContributorAuthor

@OskarStark thank you for your review.

Anything else I should do to get it merged?

Copy link

@MattsMatts left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@sylfabre After these changes LTGM

@sylfabre
Copy link
ContributorAuthor

@Matts done, thank you for your review

Copy link

@MattsMatts left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am so sorry! It seems the CI does not agree with my interpretation. Did not know that an empty line after a start of the code block is a requirement. See the required changes below. Will approve it now seeing as this is blocked by CI

@sylfabre
Copy link
ContributorAuthor

@Matts no worries!

@sylfabresylfabre deleted the messenger_override branchFebruary 2, 2021 12:18
@sylfabresylfabre restored the messenger_override branchMarch 4, 2021 14:01
@sylfabresylfabre reopened thisMar 4, 2021
@sylfabre
Copy link
ContributorAuthor

sylfabre commentedMar 4, 2021•
edited
Loading

I don't why I closed it a month ago ...

@sylfabresylfabreforce-pushed themessenger_override branch 2 times, most recently fromba8463c toa21e09dCompareMarch 4, 2021 14:29
@wouterjwouterj changed the base branch from5.x to4.4April 7, 2021 13:14
@wouterjwouterj requested a review fromxabbuh as acode ownerApril 7, 2021 13:14
@wouterj
Copy link
Member

Thank you@sylfabre for the research & documentation. I've slightly reduced the content and moved it up a bit (as we already talk a bit about inheritance at the start of the section).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@xabbuhxabbuhAwaiting requested review from xabbuh

+2 more reviewers

@MattsMattsMatts approved these changes

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sylfabre@wouterj@OskarStark@Matts@maxhelias@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp