Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Messenger] Added SQS Messenger docs#14391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fix provider name `backend_users` instead of `backend`
This PR was submitted for the 5.1 branch but it was merged into the 4.4 branch instead.Discussion----------Update user_provider.rstFix provider name `backend_users` instead of `backend`Commits-------34bacb5 Update user_provider.rst
This PR should target 5.1 |
There you go@OskarStark. Im done with this PR now |
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for taking care of this PR@Nyholm
should we talk about async-aws, and authentication mechanism that fallback to .ini files, EC2/Lambda roles, Eks webidentity... and key/secret are not required |
Hm.. Im not sure we should. Access key/secret is a really good way for new users. Advanced users will look at the code and find AsyncAws and find their way... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for contributing these docs!
| .. versionadded:: 5.1 | ||
| The Amazon SQS transport has been added in Symfony 5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We'll make this change while merging, but for your information, theversionadded messages are standardized as:XXX was introduced in Symfony N.N.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you.
I leave this unchanged then.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Note for the mergers, this must target 5.1 branch |
I've updated the PR |
This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.Discussion----------Remove Michelle from the CARE teamShe has resigned.Commits-------cb0c526 Remove Michelle from the CARE team
* 4.4: Remove Michelle from the CARE team Update user_provider.rst
Thanks@Nyholm and@Simperfit! During the merge, I mistakingly added some commits that should also have made it in 5.1 (from 4.4). So the diff of this PR is a bit weird, but the result is correct. Afterwards, I've fixed the comment of@javiereguiluz along with some minor formatting changes in23fd9b4 |
Thank you |
* 5.1: [#14391] Minor (mostly formatting) improvements Sort alphabetically Typos minor Typo Syntax fix syntax cs Added SQS Messenger docs feat: add amazon sqs to docs Remove Michelle from the CARE team Update user_provider.rst
This willclose#13328 andfix#13093