Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Collection forms] Make javascript generic#14340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

tcheymol
Copy link
Contributor

@tcheymoltcheymol commentedOct 4, 2020•
edited
Loading

This pull request aims at making javascript code on the "embeded collection form" section reusable in any form collection

  • The aim is that we only need to add a<ul> tag, and add one init line in javascript if we embed another form collection
  • Also, I think that the$addLinkLi can perfectly be added in Twig instead of javascript, it reduces the size of the js function and improoves reusability

What I did is

  • Remove the$addLinkLi from javacripts
  • Add a data attribute to it so it can reference the list container class :data-collection-holder-class

I created a sample project implementing my working solutionhere

@tcheymoltcheymolforce-pushed thecollection-forms-make-js-generic branch from34ddf47 to45d8a41CompareOctober 5, 2020 05:23
@tcheymoltcheymolforce-pushed thecollection-forms-make-js-generic branch from45d8a41 to5451488CompareOctober 26, 2020 13:37
@wouterjwouterj changed the base branch frommaster to4.4November 5, 2020 14:09
@wouterjwouterjforce-pushed thecollection-forms-make-js-generic branch from5451488 to3abecebCompareNovember 5, 2020 14:09
wouterj added a commit that referenced this pull requestNov 5, 2020
@wouterjwouterj merged commit0ceb959 intosymfony:4.4Nov 5, 2020
@wouterj
Copy link
Member

Hi@tcheymol! Thank you for these great changes and especially massive thanks for creating the demo application. It's always very hard to review changes in this article, being able to test them in a Symfony application helps a lot here.

I've done some very minor textual changes inacfe6b6

@wouterjwouterj mentioned this pull requestNov 5, 2020
wouterj added a commit that referenced this pull requestNov 5, 2020
* 4.4:  addressed issue#11786  Add array example on ChoiceType choice_attr option  [#14340] Some minor textual changes  [Collection forms] Make javascript generic  Updating the Installer Related Instructions
wouterj added a commit that referenced this pull requestNov 5, 2020
* 5.1:  addressed issue#11786  Add array example on ChoiceType choice_attr option  [#13619] Moved text into a note and added versionadded  Add wither behavior with PHP8 static return type  [#14340] Some minor textual changes  [Collection forms] Make javascript generic  Updating the Installer Related Instructions  Non-standard adder/remover methods
This was referencedOct 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@HeahDudeHeahDudeAwaiting requested review from HeahDude

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@tcheymol@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp