Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
minor [#14292] UserProvider::supportsClass#14293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CharlyPoppins commentedSep 28, 2020
|
javiereguiluz commentedSep 29, 2020
Charly, thanks for this contribution. The build error is unrelated to your changes (it was a temporary issue in another article). While we wait to see if this feature is merged in Maker bundle, we'll need to update something in this pull request:
You used the code that Maker runs to generate the code, but in the Symfony Docs we should display instead the result of executing that code. |
CharlyPoppins commentedSep 29, 2020
Silly me... I tought |
CharlyPoppins commentedSep 29, 2020
Hum, squashing made unwanted changes... I don't know how to handle this. I created a new PR :#14304 Which on of these both should be closed ? |
javiereguiluz commentedSep 30, 2020
No worries. By the way, there's no need to squash changes because the tool we use to merge PRs does that automatically for us. Closed in favor of#14304. |
symfony/maker-bundle#532