Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

minor [#14292] UserProvider::supportsClass#14293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
CharlyPoppins wants to merge3 commits intosymfony:masterfromCharlyPoppins:master

Conversation

@CharlyPoppins
Copy link
Contributor

@CharlyPoppins
Copy link
ContributorAuthor

Build documentation failed do I need to change something ?

@javiereguiluzjaviereguiluz added the Waiting Code MergeDocs for features pending to be merged labelSep 29, 2020
@javiereguiluz
Copy link
Member

Charly, thanks for this contribution. The build error is unrelated to your changes (it was a temporary issue in another article).

While we wait to see if this feature is merged in Maker bundle, we'll need to update something in this pull request:

|| is_subclass_of($class, <?= $user_short_name ?>::class; ->|| is_subclass_of(User::class);

You used the code that Maker runs to generate the code, but in the Symfony Docs we should display instead the result of executing that code.

@CharlyPoppins
Copy link
ContributorAuthor

You used the code that Maker runs to generate the code, but in the Symfony Docs we should display instead the result of executing that code.

Silly me...

I tought<?= $user_short_name ?> was something generated with/by.rst files

@CharlyPoppins
Copy link
ContributorAuthor

Hum, squashing made unwanted changes... I don't know how to handle this.

I created a new PR :#14304

Which on of these both should be closed ?

@javiereguiluz
Copy link
Member

No worries. By the way, there's no need to squash changes because the tool we use to merge PRs does that automatically for us. Closed in favor of#14304.

CharlyPoppins reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Needs ReviewWaiting Code MergeDocs for features pending to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CharlyPoppins@javiereguiluz@carsonbot@elghailani

[8]ページ先頭

©2009-2025 Movatter.jp