Translatable objects#14240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:masterfromnatewiebe13:translatable-objects

Sep 25, 2020

Merged

Translatable objects#14240

javiereguiluz merged 1 commit intosymfony:masterfromnatewiebe13:translatable-objects

Sep 25, 2020

Conversation

Copy link

natewiebe13 commentedSep 14, 2020

Goal: Add docs for translatable objects.

Feature:symfony/symfony#37670
Fixes#14145

Unsure how in-depth the docs should go. Open to feedback and collaboration.

carsonbot added the Status: Needs Review label

Sep 14, 2020

noniagriconomie reviewed

Sep 15, 2020

View reviewed changes

translation.rstShow resolvedHide resolved

apfelbox reviewed

Sep 15, 2020

View reviewed changes

translation.rstShow resolvedHide resolved

javiereguiluz added Status: Reviewed Translation and removed Status: Needs Review labels

Sep 25, 2020

javiereguiluz added this to the5.2 milestone

Sep 25, 2020

Translatable objects

a2ad274

javiereguiluz force-pushed thetranslatable-objects branch fromd463334 toa2ad274Compare

September 25, 2020 10:20

javiereguiluz merged commit88a6112 intosymfony:master

Sep 25, 2020

Copy link

Member

javiereguiluz commentedSep 25, 2020

Nate, thanks a lot for contributing both this feature and its docs. People love the new feature and this was a great first contribution to Symfony Docs. Congrats on that too!

Please note that while merging we did some rewords based on this blog post ->https://symfony.com/blog/new-in-symfony-5-2-translatable-objects. but we kept the core of your contribution. Thanks!