Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Some fixes in structure overriding page#14147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@l-vo
Copy link
Contributor

  • Usedefault_path instead ofpaths to change translation directory (default_path is anyway added to paths)
  • Replacevar byvendor in the public directory section (I think it's a typo, I don't see whyvar would be involved when public dir is customized)

In the same way, a#14135 targets 3.4 to usedefault_path instead ofpaths for templates.

@l-vol-vo changed the base branch frommaster to4.4August 28, 2020 20:38
* Use `default_path` instead of `paths` to change translation directory (default_path is anyway added to paths)* Replace `var` by `vendor` in the public directory section
@l-vol-voforce-pushed theuse_translation_default_path_to_change_directory_structure branch fromcc9376c tob65212fCompareAugust 28, 2020 20:39
@wouterj
Copy link
Member

Hi@l-vo! I was about to merge this PR, but I'm a bit confused by the target branch. If I understandsymfony/symfony#24860 correctly, this option is introduced in Symfony 3.4, is there a reason you submitted this to 4.4?

@l-vo
Copy link
ContributorAuthor

Hi@wouterj, you're right, it seems I made a mistake, I think it's because the second fix (var instead ofvendor) targets 4.4. I will push a new version for this PR and another to fixdefault_path in 3.4.

wouterj reacted with thumbs up emoji

@l-vo
Copy link
ContributorAuthor

@wouterj Finally it was not a mistake, I targeted 4.4 because overriding translation directories is not documented in3.4 ^^

wouterj reacted with thumbs up emoji

@wouterj
Copy link
Member

Ah, that makes sense. Thanks for your quick research today & proposing this fix a couple weeks ago, Laurent!

l-vo reacted with heart emoji

@wouterjwouterj merged commit2f25a69 intosymfony:4.4Oct 22, 2020
@l-vol-vo deleted the use_translation_default_path_to_change_directory_structure branchOctober 23, 2020 05:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@l-vo@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp