Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Replace overriding twig.paths by twig.default_path#14135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
yceruto approved these changesAug 27, 2020
Member
wouterj commentedOct 22, 2020
Thank you, Laurent! The difference between default_path and paths is a bit confusing, which is why it took a bit longer to merge this one. But I agree that this article isthe use-case of modifying the default path instead of paths. Thanks again! |
wouterj added a commit that referenced this pull requestOct 22, 2020
This PR was merged into the 4.4 branch.Discussion----------Some fixes in structure overriding page* Use `default_path` instead of `paths` to change translation directory (default_path is anyway added to paths)* Replace `var` by `vendor` in the public directory section (I think it's a typo, I don't see why `var` would be involved when public dir is customized)In the same way, a#14135 targets 3.4 to use `default_path` instead of `paths` for templates.Commits-------b65212f Some fixes in structure overriding:
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
twig.default_pathhas been introduced (3.4), it should be a better idea to override it instead oftwig.pathsfor customizing the directory structure (default path is added to paths anyway).