Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Notifier] Linkedin integration#14104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
wouterj left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think there is a need to rush merging (the stable release date is 3 months away), so feel free to keep this PR open a bit longer and add the other details (but we can also merge now if you would like that, it doesn't really matter).
notifier.rst Outdated
| The LinkedIn integration was introduced in Symfony | ||
| 5.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we can merge this on one line :) (we don't have a very strict max line length rule, it should break somewhere around the 72th character)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was done while merging. Thanks!
300522d to74041eeComparejaviereguiluz commentedAug 31, 2020
Thank you@ismail1432. |
Fix#14099
I'm wondering if we merge this and then I add an example like it's donehttps://symfony.com/doc/master/notifier/chatters.html#adding-interactions-to-a-slack-message or we wait until I add the example in 1 PR