Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Complete documentation about mailer integration#14083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:5.2froml-vo:complete_mailer_integration
Nov 21, 2020

Conversation

l-vo
Copy link
Contributor

@l-vol-vo commentedAug 16, 2020•
edited
Loading

Close#14066

@l-vol-voforce-pushed thecomplete_mailer_integration branch from2a9f700 to0cd93b0CompareAugust 16, 2020 14:22
@l-vol-voforce-pushed thecomplete_mailer_integration branch 6 times, most recently froma8ed262 to962111bCompareAugust 17, 2020 07:12
@wouterjwouterj added this to the5.2 milestoneOct 3, 2020
@xabbuhxabbuh changed the base branch frommaster to5.xOctober 6, 2020 11:54
@xabbuh
Copy link
Member

Should parts of this be merged into the4.4 branch?

@l-vo
Copy link
ContributorAuthor

Nomessage_bus andheaders semantic configuration key were added in 5.x. So is the native mailer transport. I will try to fix conflicts tonight :)

@l-vo
Copy link
ContributorAuthor

My bad, this PR include mailer configuration which should be available in 4.4. I will do another PR targeting 4.4.

wouterj reacted with thumbs up emoji

@l-vol-voforce-pushed thecomplete_mailer_integration branch 2 times, most recently from6a54032 tob212f63CompareNovember 17, 2020 21:18
@l-vo
Copy link
ContributorAuthor

@xabbuh PR rebased +#14565 created to report changes on 4.4

xabbuh reacted with thumbs up emoji

@l-vol-voforce-pushed thecomplete_mailer_integration branch fromb212f63 toc05bdffCompareNovember 19, 2020 20:14
wouterj added a commit that referenced this pull requestNov 21, 2020
This PR was merged into the 4.4 branch.Discussion----------[Mailer] Complete mailer documentationChanges of#14083 reported to 4.4.Commits-------074db0d Complete mailer integration
wouterj added a commit that referenced this pull requestNov 21, 2020
* 4.4:  [#14083] Revert mailer.headers option in 4.4 - 5.1
wouterj added a commit that referenced this pull requestNov 21, 2020
* 5.1:  [#14083] Revert mailer.headers option in 4.4 - 5.1
@wouterjwouterj changed the base branch from5.x to5.2November 21, 2020 20:04
@wouterjwouterjforce-pushed thecomplete_mailer_integration branch fromc05bdff toa389dfbCompareNovember 21, 2020 20:04
@wouterjwouterj merged commitb1a157b intosymfony:5.2Nov 21, 2020
wouterj added a commit that referenced this pull requestNov 21, 2020
* 5.2:  Complete documentation about mailer integration  Complete documentation about mailer integration  [#14083] Revert mailer.headers option in 4.4 - 5.1
@l-vol-vo deleted the complete_mailer_integration branchNovember 21, 2020 20:06
@wouterj
Copy link
Member

Hi@l-vo! So this was quite a merge 😅 Just to let you know what I did:

  • I merged your new 4.4 PR ([Mailer] Complete mailer documentation #14565) and removed theheaders setting from it (as it was introduced in 5.2)
  • I added themessage_bus to the 5.1 branch (1da6b0b), as I believe that's where it was introduced
  • I merged this PR, minus all changes that were already done in 5.2. I believe both the native protocol andheaders option were introduced in 5.2
  • At last, I foundAdd mailer in framework config reference #14087 which is also from you and had almost the same changes as your new 4.4 branch. I've closed that one, as I believe we both simply forgot about this PR and the changes are now already done.

@l-vo
Copy link
ContributorAuthor

@wouterj oh sorry for the double PR targeting 4.4, I sawthis comment and then I forgot I already did a PR targeting 4.4 😅. Thank you for your explanations and your updates on it 👍

OskarStark added a commit to OskarStark/symfony-docs that referenced this pull requestNov 25, 2020
* 5.1: (31 commits)  Fix package name for OvhCloud notifier  Fix wrong key name  Enhancement: Streamline workflow  GitHub Actions: use docker container for CI build  Bus restricting with Interfaces  Security: add example code which Maker Bundle generated  [symfony#14550] Reduce nr of lines used for exception  Section method only in ConsoleOutputInterface  Added a new troubleshooting section in the maintainer guide  Removed duplicated line  Complete documentation about mailer integration  [symfony#14083] Revert mailer.headers option in 4.4 - 5.1  Removed 4.3 versionadded directive  [symfony#14565] Minor formatting fixes  Updated getParent() description with the why/when (thanks javier!)  [Form] Added explicit `getParent()` call in types inheritance mechanism  Added PHP types to the DI related articles  Added PHP types to the Form related articles  Added PHP types to the Doctrine related articles  Tweak  ...
This was referencedOct 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[Mailer] Add a transport that uses php.ini settings for configuration
4 participants
@l-vo@xabbuh@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp