Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Browserkit] The Client class has been replaced by the AbstractBrowser since SF 4.3#13550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
javiereguiluz merged 1 commit intosymfony:4.4fromfulgens-sprl:update-browserkit-client-to-browserJun 8, 2020
Merged
[Browserkit] The Client class has been replaced by the AbstractBrowser since SF 4.3#13550
javiereguiluz merged 1 commit intosymfony:4.4fromfulgens-sprl:update-browserkit-client-to-browserJun 8, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2c0402b toa3ff4e0CompareMember
javiereguiluz commentedJun 8, 2020
@Calex92 thanks and congrats on your first Symfony Docs contribution! (sorry it took us so long to merge) |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in the BrowserKit documentation, there was multiple references to the old
Symfony\Component\BrowserKit\Clientclass instead of theSymfony\Component\BrowserKit\AbstractBrowserone.Seesymfony/symfony#30541
There was a previous merge request for SF5 here (#12717), but I don't know if it was possible for me to use it since I'm quite new with Github best practice about contribution.
Don't hesitate to tell me if I'm wrong!