Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
RepeatedType overridesmapped value for the type to work properly#13519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
RepeatedType overridesmapped value for the type to work properly#13519
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e7d9a61 to6bc157fCompare
HeahDude left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks again! Some minor comments
reference/forms/types/repeated.rst Outdated
| 'second_options' => ['label' => 'Repeat Password'], | ||
| ]); | ||
| ..note:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What about line 100 instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For me this is most logic place to have a note about options. I would like to have a note about this exactly at the place where documentation describes options for inner fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this information is too important and should be shown before any options. This is needed in order to handle validation, and the line I linked is about that section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Okay. Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, I leave that one open for now.
Uh oh!
There was an error while loading.Please reload this page.
6bc157f to94980d2Compare94980d2 tob29335aCompareHeahDude commentedApr 11, 2020
Side note: we should wait next patch of 3.4 before merging here. |
…(biozshock)This PR was merged into the 3.4 branch.Discussion----------[Form] RepeatedType should always have inner types mapped| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Doc PR|symfony/symfony-docs#13519 || Tickets |Fix#36410| License | MITAlways set mapped=true to override inner type mapped setting.Throw an exception if inner types of RepeatedType has mapped=falseCommits-------728cd66 RepeatedType should always have inner types mapped
…(biozshock)This PR was merged into the 3.4 branch.Discussion----------[Form] RepeatedType should always have inner types mapped| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Doc PR|symfony/symfony-docs#13519 || Tickets | Fix #36410| License | MITAlways set mapped=true to override inner type mapped setting.Throw an exception if inner types of RepeatedType has mapped=falseCommits-------728cd66a13 RepeatedType should always have inner types mapped
javiereguiluz commentedSep 25, 2020
Thank you Artem. |
Add a note to the documentation about overridden
mappedoption for inner fields.