Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
No longer recommend injecting the service container#13486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
javiereguiluz merged 1 commit intosymfony:masterfromwouterj:issue-13469/containerinterface-aliasApr 6, 2020
Merged
No longer recommend injecting the service container#13486
javiereguiluz merged 1 commit intosymfony:masterfromwouterj:issue-13469/containerinterface-aliasApr 6, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
07e91ef to156ac13Comparemaxhelias approved these changesApr 4, 2020
Thanks Wouter! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#13469
I think it makes sense to no longer document injecting the service container. Service subscriber is the better alternative in any case.
I actually also thought about removing setting a service public at all. But let's keep it for now (it is sometimes usefull in tests see e.g.symfony/symfony#36147 and#12647 . It's also a bit weird to have a "Public Versus Private Services" section that only discusses "private" services