Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Forms] Add empty_data to the form HiddenType#13458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:3.4fromosavchenko:add-empty-data-to-the-hidden-field
Apr 1, 2020
Merged

[Forms] Add empty_data to the form HiddenType#13458

javiereguiluz merged 1 commit intosymfony:3.4fromosavchenko:add-empty-data-to-the-hidden-field
Apr 1, 2020

Conversation

@osavchenko
Copy link
Contributor

Fixes#13401.

@javiereguiluz
Copy link
Member

Thank you Oleksandr.

@javiereguiluzjaviereguiluz merged commit0cda846 intosymfony:3.4Apr 1, 2020
@xabbuh
Copy link
Member

Please note that I agree with this change, but that blindly using theempty_data option is not the general solution for the problem laid out in#13401. Furthermore, theempty_data option is available in all other form types too. So maybe someone would like to submit a PR syncing all of them?

@osavchenkoosavchenko deleted the add-empty-data-to-the-hidden-field branchApril 1, 2020 09:11
@osavchenko
Copy link
ContributorAuthor

@xabbuh I have a question about other options. Could you please advise me?

We haveHiddenType which is inherited fromFormType and of course, some options are missed here, but I have checked TextType which is also inherited from FormType and onTextType we can find missed inherited options too. So, should we document all inherited options even if it looks useless like a label for the hidden type or we should use some rules for documenting options?

@HeahDude
Copy link
Contributor

ref#6265 (comment)

@osavchenko
Copy link
ContributorAuthor

@HeahDude Your notice was aboutDEFAULT_PLACEHOLDER?

javiereguiluz added a commit that referenced this pull requestApr 3, 2020
…eld (osavchenko)This PR was merged into the 3.4 branch.Discussion----------[Forms] fix displaying `empty_data` option for hidden fieldI made a mistake on my previous PR#13458 which cause new issue#13471.Fixes#13471.Commits-------4a4d155 fix displaying `empty_data` option for hidden field
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@osavchenko@javiereguiluz@xabbuh@HeahDude@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp