Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Changing the "jQuery" part#13450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Most important:* Get rid of this complicated JavaScript block that does nothing but append the "add tags" link. The link is now just rendered in the Twig block, and "activated" in the JavaScript block. If somebody wants to have it more fancy, they need to figure it out themselves - this is no JavaScript tutorial ;-) Besides, the `ul` approach used here probably won't fit for all users - so they need to adjust it anyway...Less important:* Shortening the text* Including link to jQuery
Sorry, don't know what this means (same in previous PR#13449 ):
|
Shortening the next paragraph. It should be moved downward, just after the code block, but I'm leaving this for a separate PR ;-)
Don't merge this yet! The JavaScript is not working yet. How can we proceed? Should I update the Fiddle first? |
Hi@ThomasLandauer! I've just merged a PR (#14340) that also removed the append "add tags" link from the JavaScript. I tried to rebase your PR or review the changes, but as there have been other textual changes that was near impossible. So I fear there is nothing else than closing this and asking you to open a new PR if you think important changes have been missed. As a tip for the next time, reviewing changes in a PR that both moved things around and edited things is very hard. I know it feels a bit counter-intuative when working on a PR, but please try to separate moving things from changing things (e.g. in separate commits by creating separate PRs). |
As a separate PR, as recommended bysymfony#13450 (comment)
As a separate PR, as recommended bysymfony#13450 (comment)* Reason for deleting "Add a script tag somewhere on your page...": Lenghthy text that didn't say much ;-)* Reason for deleting the `note`: The JavaScript code is shown in itself; not inside some HTML ;-)*
As a separate PR, as recommended bysymfony#13450 (comment)Note: `addTagForm` was the wrong function name, it's now called `addFormToCollection()`
…dauer)This PR was merged into the 4.4 branch.Discussion----------Shortening the text and adding link to jQueryAs a separate PR, as recommended by#13450 (comment)Commits-------853dfb0 Shortening the text and adding link to jQuery
This PR was merged into the 4.4 branch.Discussion----------Shortening the text some moreAs a separate PR, as recommended by#13450 (comment)* Reason for deleting "Add a script tag somewhere on your page...": Lenghthy text that didn't say much ;-)* Reason for deleting the `note`: The JavaScript code is shown in itself; not inside some HTML ;-)Commits-------dc794b9 Shortening the text some more
This PR was merged into the 4.4 branch.Discussion----------[Form] RewordingAs a separate PR, as recommended by#13450 (comment)Note: `addTagForm` was the wrong function name, it's now called `addFormToCollection()`Commits-------d015c96 Rewording
Most important:
Besides, the
ulapproach used here probably won't fit for all users - so they need to adjust it anyway...Less important: