[Form] Add description of label_html option#13316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:masterfromprzemyslaw-bogusz:label_html

Mar 14, 2020

Merged

[Form] Add description of label_html option#13316

javiereguiluz merged 1 commit intosymfony:masterfromprzemyslaw-bogusz:label_html

Mar 14, 2020

Conversation

Copy link

Contributor

przemyslaw-bogusz commentedMar 8, 2020•
edited
Loading

Q	A
Feature PR	symfony/symfony#31375
PR author(s)	@przemyslaw-bogusz
Merged in	WCM

przemyslaw-bogusz requested a review fromxabbuh as acode owner

March 8, 2020 10:41

carsonbot added the Status: Needs Review label

Mar 8, 2020

przemyslaw-bogusz mentioned this pull request

Mar 8, 2020

[Form] Add label_html attributesymfony/symfony#31375

Merged

przemyslaw-bogusz changed the title~~Add description of label_html option~~[WCM] Add description of label_html option

Mar 8, 2020

przemyslaw-bogusz changed the title~~[WCM] Add description of label_html option~~[Form][WCM] Add description of label_html option

Mar 8, 2020

OskarStark added the Waiting Code MergeDocs for features pending to be merged label

Mar 9, 2020

OskarStark added this to the5.1 milestone

Mar 9, 2020

nicolas-grekas added a commit to symfony/symfony that referenced this pull request

Mar 12, 2020

feature#31375[Form] Add label_html attribute (przemyslaw-bogusz)

49e5d57

This PR was squashed before being merged into the 5.1-dev branch.Discussion----------[Form] Add label_html attribute| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MIT| Doc PR        |symfony/symfony-docs#13316I propose to add a new attribute to `BaseType` class so it is easy to include html tags in labels for, both, buttons and other elements that inherit from `FormType` class. This gives you an ability to add, e.g. a glyphicon to a button, or a link to a checkbox, simply inside the `FormBuilder`, which means you can just do```twig{{ form(form) }}```inside a template.**Sidenotes**1. I have started working on this two days ago and it the meantime@alexander-schranz made a similar proposition in#31358. If necessary, I can close my PR and@alexander-schranz can include my suggestions inside his PR.1. I have just read in#29861 that@mpiot wanted to include this idea in his PR. With respect to@xabbuh's comments from that PR, I hope that my PR will be at least a good place to discuss, if the proposed feature is a good solution.Commits-------239fe04 [Form] Add label_html attribute

symfony-splitter pushed a commit to symfony/form that referenced this pull request

Mar 12, 2020

feature #31375 [Form] Add label_html attribute (przemyslaw-bogusz)

89686cc

This PR was squashed before being merged into the 5.1-dev branch.Discussion----------[Form] Add label_html attribute| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MIT| Doc PR        |symfony/symfony-docs#13316I propose to add a new attribute to `BaseType` class so it is easy to include html tags in labels for, both, buttons and other elements that inherit from `FormType` class. This gives you an ability to add, e.g. a glyphicon to a button, or a link to a checkbox, simply inside the `FormBuilder`, which means you can just do```twig{{ form(form) }}```inside a template.**Sidenotes**1. I have started working on this two days ago and it the meantime@alexander-schranz made a similar proposition in #31358. If necessary, I can close my PR and@alexander-schranz can include my suggestions inside his PR.1. I have just read in #29861 that@mpiot wanted to include this idea in his PR. With respect to@xabbuh's comments from that PR, I hope that my PR will be at least a good place to discuss, if the proposed feature is a good solution.Commits-------239fe04ff9 [Form] Add label_html attribute