The following issue has been addressed: Repeated entry in the Serializer components doc#11786
The separate documentations for XMLEncoder were put into one section with minor changes in text. The documentation now contains one single section for XMLEncoder.

carsonbot added the Status: Needs Review label

Feb 27, 2020

Copy link

ContributorAuthor

armin-github commentedFeb 27, 2020

In the patch: the title 'The Context parameter of XmlEncoder' will probably need to be entirely underlined with the correct markup (~~~~~~~~~~~~~~~~~~), so the markup test will pass.

Copy link

Contributor

OskarStark commentedFeb 27, 2020

Thanks for your contribution, however I am unable to see the real difference, as most of the content is just moved around.

Can you please point me to the lines which makes sth more clear than before? Thanks

Copy link

ContributorAuthor

armin-github commentedFeb 27, 2020

Sure!
The original issue (#11786) point out the repeated entry regarding XMLEncoder in the documentation. The original documentation is split regarding this into two separate sections which is indeed confusing. what I have done is basically merging the two sections into one in an order that is now easier to follow for the reader.

maxhelias mentioned this pull request

Oct 9, 2020

[Serializer] Add missing options context#14384

Merged

addressed issuesymfony#11786

0163ab3

The following issue has been addressed: Repeated entry in the Serializer components docsymfony#11786The separate documentations for XMLEncoder were put into one section with minor changes in text. The documentation now contains one single section for XMLEncoder.

wouterj changed the base branch from5.0 to4.4

November 5, 2020 17:16

wouterj requested review fromHeahDude andxabbuh ascode owners

November 5, 2020 17:16

wouterj force-pushed thepatch-1 branch from4babdfc to0163ab3Compare

November 5, 2020 17:16

Copy link

Member

wouterj commentedNov 5, 2020

Hi@armin-github! I'm very sorry for the long wait, I'm not sure why we've missed this. The PR makes a lot of sense, the duplicate sections should indeed be merged.

wouterj merged commitcf34c42 intosymfony:4.4

Nov 5, 2020

wouterj mentioned this pull request

Nov 5, 2020

[Serializer] Merge encoder sections and show options in a table#14521

Merged

wouterj added a commit that referenced this pull request

Nov 8, 2020

minor#14521[Serializer] Merge encoder sections and show options in …

59bee3e

…a table (wouterj)This PR was merged into the 4.4 branch.Discussion----------[Serializer] Merge encoder sections and show options in a tableWhile merging#13269 , I found that we also documented CsvEncoder options in a different section. This merges both duplicated sections.I've also transformed them to a table, similar to the recent changes to documenting the provider options in the Messenger guide.Commits-------d397c38 Merge encoder sections and show options in a table