Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Form] added the "choice_filter" option#13223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7194302 to526612cComparea2c2649 to44b0d14Comparefabpot added a commit to symfony/symfony that referenced this pull requestMar 16, 2020
…eahDude)This PR was merged into the 5.1-dev branch.Discussion----------[Form] Added a "choice_filter" option to ChoiceType| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | yes| Tickets |Fix#32657| License | MIT| Doc PR |symfony/symfony-docs#13223Finally opening this PR for a very old branch, based on both#34550 (merged) and#30994 (merged).~Until#30994 is merged, this PR should better be reviewed by commits. Thanks!~Commits-------ed2c312 [Form] Added a "choice_filter" option to ChoiceType
javiereguiluz approved these changesApr 3, 2020
Member
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks good to me.@HeahDude do you consider it finished? Thanks!
Uh oh!
There was an error while loading.Please reload this page.
44b0d14 to5314a87Compare5314a87 tob48c500Compareb48c500 to8b0c09eCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation forsymfony/symfony#35733.
Based on#13182 for now, so better be reviewed by commit here until it's merged and rebased, thanks!