Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Documented the Hostname constraint#13167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
HeahDude merged 1 commit intosymfony:masterfromjaviereguiluz:fix_12923
Feb 20, 2020

Conversation

javiereguiluz
Copy link
Member

Fixes#12923.

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is one error left:

Warning, treated as error:/home/runner/work/symfony-docs/symfony-docs/reference/constraints/Hostname.rst:: WARNING: document isn't included in any toctree

@javiereguiluz
Copy link
MemberAuthor

Oskar, I don't understand the error message because I linked the file from this file:https://github.com/symfony/symfony-docs/pull/13167/files#diff-5c99f0007238ae4a681869aa8713c3fd

@OskarStark
Copy link
Contributor

Copy link
Contributor

@HeahDudeHeahDude left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've fixed the toctree

OskarStark reacted with thumbs up emoji
@OskarStark
Copy link
Contributor

@javiereguiluz can you please squash or at least your two commits? Otherwise I cannot merge this, thanks!

@HeahDude
Copy link
Contributor

Thanks Javier.

@HeahDudeHeahDude merged commitd0b800f intosymfony:masterFeb 20, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@noniagriconomienoniagriconomienoniagriconomie left review comments

@OskarStarkOskarStarkOskarStark approved these changes

@HeahDudeHeahDudeHeahDude approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Validator] Added HostnameValidator
5 participants
@javiereguiluz@OskarStark@HeahDude@noniagriconomie@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp