Related to#13023 andsymfony/symfony#9336
This is not a complete documentation for related issues, but this will introduce one of the possible new use.

carsonbot added the Status: Needs Review label

Feb 14, 2020

Korbeil changed the title~~Non-standard adder/remover methods~~[PropertyAccess] Non-standard adder/remover methods

Feb 14, 2020

HeahDude added this to the4.4 milestone

Feb 19, 2020

HeahDude added the PropertyAccess label

Feb 19, 2020

wouterj added the Waiting Code MergeDocs for features pending to be merged label

Oct 22, 2020

Copy link

Member

wouterj commentedOct 22, 2020

Fyi: Marked as "waiting code merge" as I think it depends onsymfony/symfony#38515

Copy link

ContributorAuthor

Korbeil commentedOct 22, 2020•
edited
Loading

@wouterj I does not depends on that PR, it was dependant onsymfony/symfony#30704 which I finished a long time ago ^^
The PR you linked is only DX to make that overwrite easier (but not covered in this documentation).

Copy link

Member

wouterj commentedOct 22, 2020

Oh, I'm sorry. I thought that PR only did changes to PropertyInfo and missed the big changes to the PropertyAccessor.

wouterj removed the Waiting Code MergeDocs for features pending to be merged label

Oct 22, 2020

wouterj requested changes

Oct 22, 2020

View reviewed changes

Copy link

Member

wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@Korbeil! I've proposed some changes to slightly improve the code example.

Can you please also add a versionadded directive like:

..versionadded::5.1    Support for non-standard adder/remover methods was introduced in Symfony 5.1.

And at last, please rebase this PR on the 5.1 branch (usinggit rebase --onto origin/5.1 origin/master).

If you don't have time to work on these changes (or something is unclear), please tell me and I'll finish this PR.

components/property_access.rst OutdatedShow resolvedHide resolved

components/property_access.rstShow resolvedHide resolved

components/property_access.rst OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Oct 22, 2020

Korbeil changed the base branch frommaster to5.1

October 23, 2020 11:42

Korbeil force-pushed thefeature/add-non-standard-adder-remover-methods branch from62f43d9 tob710816Compare

October 23, 2020 11:42

Korbeil requested review fromHeahDude andxabbuh ascode owners

October 23, 2020 11:42

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Oct 23, 2020

Non-standard adder/remover methods

bf6cca9

Korbeil force-pushed thefeature/add-non-standard-adder-remover-methods branch fromb710816 tobf6cca9Compare

October 23, 2020 11:45

Copy link

ContributorAuthor

Korbeil commentedOct 23, 2020

@wouterj I made all requested changes

wouterj approved these changes

Oct 23, 2020

View reviewed changes

Copy link

Member

wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the quick response@Korbeil!

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Oct 23, 2020

maxhelias approved these changes

Oct 25, 2020

View reviewed changes

Copy link

Member

wouterj commentedOct 31, 2020

Hi@Korbeil. I was about to merge this PR but I'm lost in all the core commits and PRs again.. This PR has got the "4.4" milestone, which makes me think it should be merged in 4.4. But it appears like the feature is introduced in 5.1. Can you please confirm which version should be used?

Copy link

ContributorAuthor

Korbeil commentedNov 1, 2020

@wouterj, As you can see in related PR:symfony/symfony#30704 It was firstly tagged inv5.1.0-BETA1

Or maybe it's my github enhanced addon that shows it ?

Copy link

Member

wouterj commentedNov 1, 2020

Oh, I don't have that feature. That seems extremely useful 😄

You probably submitted this PR when 4.4 was in development, causing a doc team member to flag it as4.4 a bit too quickly. I'll merge in 5.1 then, thanks for confirming.