Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Workflow: align Example for property access with implementation of Me…#12988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Workflow: align Example for property access with implementation of Me…#12988
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@lyrixx can you please have a look here? Thanks 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Indeed, It remove the support via Property Accessor to use a plain PHP Method
Uh oh!
There was an error while loading.Please reload this page.
@lyrixx I'm going to merge this. I saw that the same change can be done in 3.4 branch. Is that correct ... or does this only work starting from another branch? Thanks! |
@javiereguiluz Thanks for seeking :) But nope. It's only for Symfony 4.3 (so 4.4) |
f295d08 to5272a25CompareOskarStark commentedJan 30, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you Simon and congrats on your first contribution to the Symfony documentation 🎉 |
…ation of Me… (simon-schubert)This PR was submitted for the 4.4 branch but it was squashed and merged into the 4.3 branch instead (closes#12988).Discussion----------Workflow: align Example for property access with implementation of Me…The Implementation in Symfony\Component\Workflow\MarkingStore\MethodMarkingStore does not use symfony/property-access (as the former implementations like e.g. SingleStateMarkingStore did) and requires to have getter/setter implemented in your entity. Therefore the example in docs does not work (any longer). I don't know, why the usage of symfony/property-access was dropped, but it seemed to me not accidentally. That's why I decided to send a PR to update docs. But maybe the implementation is "wrong" and should be changed instead. So please check carefully. Thank you.Commits-------5272a25 Workflow: align Example for property access with implementation of Me…
thank you@OskarStark ,@javiereguiluz and@lyrixx 😄 |
The Implementation in Symfony\Component\Workflow\MarkingStore\MethodMarkingStore does not use symfony/property-access (as the former implementations like e.g. SingleStateMarkingStore did) and requires to have getter/setter implemented in your entity. Therefore the example in docs does not work (any longer). I don't know, why the usage of symfony/property-access was dropped, but it seemed to me not accidentally. That's why I decided to send a PR to update docs. But maybe the implementation is "wrong" and should be changed instead. So please check carefully. Thank you.