Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add Canonicalize option to Locale Constraint#12984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
zairigimad wants to merge6 commits intosymfony:5.0fromzairigimad:patch-8

Conversation

@zairigimad
Copy link
Contributor

@zairigimadzairigimad commentedJan 24, 2020•
edited by javiereguiluz
Loading

Add Canonicalize option to Locale Constraint (which was added in Symfony 4.1:https://symfony.com/index.php/blog/new-in-symfony-4-1-validator-improvements)

@OskarStark
Copy link
Contributor

@ro0NL can you please have a look here? Thanks!

Copy link
Contributor

@ro0NLro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

zairigimadand others added3 commitsJanuary 25, 2020 13:37
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
@OskarStark
Copy link
Contributor

For 3.4 I guess?

@zairigimadzairigimad changed the base branch from5.0 to3.4January 25, 2020 13:24
@zairigimadzairigimad changed the base branch from3.4 to5.0January 25, 2020 13:25
Options - `groups`_
- `message`_
- `payload`_
_ `canonicalize`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@javiereguiluz shall we sort them in alpha order?

javiereguiluz and zairigimad reacted with thumbs up emoji
@javiereguiluzjaviereguiluz added this to the4.4 milestoneFeb 3, 2020
@javiereguiluz
Copy link
Member

I remembered that this option was already documented. It was merged here:https://github.com/symfony/symfony-docs/pull/9248/files . So I don't understand how/when it was lost 🤔

zairigimad reacted with thumbs up emoji

zairigimadand others added2 commitsFebruary 3, 2020 13:41
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
@OskarStark
Copy link
Contributor

@javiereguiluz are you able to finalize this PR?

@wouterj
Copy link
Member

This option was introduced in 4.1 bysymfony/symfony#26075 as a backwards compatibility layer. In 4.1 setting it to anything different thantrue was deprecated bysymfony/symfony#26075 and this setting was removed in Symfony 5.0 (keeping a setting that is only allowed to betrue is non-sense) insymfony/symfony#31898

We then correctly also removed this option from the Symfony 5.0+ docs in
ce64ac2#diff-08df604c59d5284048fac6277839ca0dL92

To me, it seems perfectly fine that this option is not documented in 5.0 and master. In the 4.4 version of the docs, this option is still visible:https://symfony.com/doc/4.4/reference/constraints/Locale#canonicalize

For these reasons, I'm closing this PR.

@wouterjwouterj closed thisFeb 9, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

+1 more reviewer

@ro0NLro0NLro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@zairigimad@OskarStark@javiereguiluz@wouterj@ro0NL@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp