Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Adding details about recipe upgrade system and upgrade improvements#12959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
setup/upgrade_major.rst Outdated
- "symfony/config": "4.4.*", | ||
+ "symfony/config": "5.0.*", | ||
- "symfony/console": "4.4.*", | ||
+ "symfony/console": "5.0.*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thought the diff rormat would be more useful here.
Also, in practical terms, ever since theextra.symfony.require
key was added, when you intall a Symfony package, it uses the version constraint format4.4.*
not^4.4
. And so, for consistency, I'm showing that format and telling people to continue using it.
076636c
to036532c
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice addition
@@ -1,7 +1,7 @@ | |||
.. index:: | |||
single: Upgrading; Major Version | |||
Upgrading a Major Version (e.g.3.4.0 to4.1.0) | |||
Upgrading a Major Version (e.g.4.4.0 to5.0.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Time flies!
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great job!
I'm sorry to have left so many comments on this, mostly rewording, PR.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
- "symfony/config": "4.3.*", | ||
+ "symfony/config": "4.4.*", | ||
- "symfony/console": "4.3.*", | ||
+ "symfony/console": "4.4.*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are we sure this is the case? (I'm on Windows atm, so I cannot test it)
If I'm readinghttps://github.com/symfony/skeleton/blob/master/composer.json correctly, the dependencies are actually marked as*
and theextra.symfony.require
is used to limit the scope to a specific minor version. That would mean you only need to update that value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes ... that's how I've seen it in modern Symfony apps ... but the reader of this document can use any method actually, especially if they are upgrading from very old Symfony versions.
weaverryanJan 26, 2020 • edited by javiereguiluz
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by javiereguiluz
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In practice, when youcompose require symfony/something
, it will put theX.X.*
version constraint in your composer.json file. So... I'm trying to show an example that will look "like" the user's composer.json file. But technically speaking, you're totally right: if they had^4.0
everywhere, they could upgrade/control the Symfony versionssimply by changingextra.symfony.require
. But that's not how things currently will look in real apps.
I talked with Nicolas about this, and I think it (the usage theX.X.*
format bycomposer require
) was more-or-less an "accidental" by-product of theextra.symfony.require
feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Very nice improvements. Thanks Ryan!
Thanks everyone for the review - this should be ready now :) |
d423e58
to6305e83
CompareThank you Ryan. |
…mprovements (weaverryan)This PR was squashed before being merged into the 4.3 branch (closes#12959).Discussion----------Adding details about recipe upgrade system and upgrade improvementsHi!The big thing here is to mention the new Flex commands related to upgrading secrets. Also, the major upgrade version doc was out-of-date. Apologies if there is already a PR open to fix this (if there is, I missed it).Cheers!Commits-------6305e83 Adding details about recipe upgrade system and upgrade improvements
Hi!
The big thing here is to mention the new Flex commands related to upgrading secrets. Also, the major upgrade version doc was out-of-date. Apologies if there is already a PR open to fix this (if there is, I missed it).
Cheers!