Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adding details about recipe upgrade system and upgrade improvements#12959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:4.3fromweaverryan:updating-recipes
Jan 26, 2020

Conversation

weaverryan
Copy link
Member

Hi!

The big thing here is to mention the new Flex commands related to upgrading secrets. Also, the major upgrade version doc was out-of-date. Apologies if there is already a PR open to fix this (if there is, I missed it).

Cheers!

maxhelias reacted with rocket emoji
- "symfony/config": "4.4.*",
+ "symfony/config": "5.0.*",
- "symfony/console": "4.4.*",
+ "symfony/console": "5.0.*",
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thought the diff rormat would be more useful here.

Also, in practical terms, ever since theextra.symfony.require key was added, when you intall a Symfony package, it uses the version constraint format4.4.* not^4.4. And so, for consistency, I'm showing that format and telling people to continue using it.

Copy link
Contributor

@94noni94noni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice addition

@@ -1,7 +1,7 @@
.. index::
single: Upgrading; Major Version

Upgrading a Major Version (e.g.3.4.0 to4.1.0)
Upgrading a Major Version (e.g.4.4.0 to5.0.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Time flies!

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great job!

I'm sorry to have left so many comments on this, mostly rewording, PR.

- "symfony/config": "4.3.*",
+ "symfony/config": "4.4.*",
- "symfony/console": "4.3.*",
+ "symfony/console": "4.4.*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are we sure this is the case? (I'm on Windows atm, so I cannot test it)

If I'm readinghttps://github.com/symfony/skeleton/blob/master/composer.json correctly, the dependencies are actually marked as* and theextra.symfony.require is used to limit the scope to a specific minor version. That would mean you only need to update that value?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes ... that's how I've seen it in modern Symfony apps ... but the reader of this document can use any method actually, especially if they are upgrading from very old Symfony versions.

Copy link
MemberAuthor

@weaverryanweaverryanJan 26, 2020
edited by javiereguiluz
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In practice, when youcompose require symfony/something, it will put theX.X.* version constraint in your composer.json file. So... I'm trying to show an example that will look "like" the user's composer.json file. But technically speaking, you're totally right: if they had^4.0 everywhere, they could upgrade/control the Symfony versionssimply by changingextra.symfony.require. But that's not how things currently will look in real apps.

I talked with Nicolas about this, and I think it (the usage theX.X.* format bycomposer require) was more-or-less an "accidental" by-product of theextra.symfony.require feature

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very nice improvements. Thanks Ryan!

@weaverryan
Copy link
MemberAuthor

Thanks everyone for the review - this should be ready now :)

@javiereguiluzjaviereguiluz added this to the4.3 milestoneJan 26, 2020
@javiereguiluz
Copy link
Member

Thank you Ryan.

javiereguiluz added a commit that referenced this pull requestJan 26, 2020
…mprovements (weaverryan)This PR was squashed before being merged into the 4.3 branch (closes#12959).Discussion----------Adding details about recipe upgrade system and upgrade improvementsHi!The big thing here is to mention the new Flex commands related to upgrading secrets. Also, the major upgrade version doc was out-of-date. Apologies if there is already a PR open to fix this (if there is, I missed it).Cheers!Commits-------6305e83 Adding details about recipe upgrade system and upgrade improvements
@javiereguiluzjaviereguiluz merged commit6305e83 intosymfony:4.3Jan 26, 2020
OskarStark added a commit that referenced this pull requestJan 27, 2020
OskarStark added a commit that referenced this pull requestJan 27, 2020
OskarStark added a commit that referenced this pull requestJan 27, 2020
OskarStark added a commit that referenced this pull requestJan 27, 2020
* 5.0:  Fix build. Refs#12959
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@94noni94noni94noni left review comments

@wouterjwouterjwouterj requested changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

5 participants
@weaverryan@javiereguiluz@wouterj@94noni@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp