[Testing] Fix broken link#12881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:5.0fromMrYamous:testing-broken-link

Mar 12, 2020

Merged

[Testing] Fix broken link#12881

javiereguiluz merged 1 commit intosymfony:5.0fromMrYamous:testing-broken-link

Mar 12, 2020

Conversation

Copy link

Contributor

MrYamous commentedJan 2, 2020

Fix a broken link here :https://symfony.com/doc/current/testing.html#ajax-requests

Symfony/Component/BrowserKit/Client has been replaced by Symfony/Component/BrowserKit/AbstractBrowser in 5.0

Fix broken link

0117fe5

carsonbot added the Status: Needs Review label

Jan 2, 2020

Copy link

Member

javiereguiluz commentedJan 3, 2020

You are right ... but instead of AbstractBrowser, which is an abstract class that cannot be instantiated ... we should use HttpBrowser, right?

Copy link

ContributorAuthor

MrYamous commentedJan 3, 2020•
edited
Loading

Yes, HttpBrowser should be used, but I think that since the goal here is to show the xmlHttpRequest method, it makes sense to point to the file that implements it, do you agree ?

Or, as there are some other methods from the same page that do not point to their implementation, perhaps this link can be removed if it is not necessary.