[String] Replace codePoint by codePointsAt#12876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:5.0fromfancyweb:string-code-points-at

Jan 2, 2020

Merged

[String] Replace codePoint by codePointsAt#12876

javiereguiluz merged 1 commit intosymfony:5.0fromfancyweb:string-code-points-at

Jan 2, 2020

Conversation

Copy link

Contributor

fancyweb commentedJan 1, 2020

symfony/symfony#33940 renamed thecodePoint method tocodePointsAt.

[String] Replace codePoint by codePointsAt

d507793

carsonbot added the Status: Needs Review label

Jan 1, 2020

javiereguiluz added Status: Reviewed String and removed Status: Needs Review labels

Jan 2, 2020

javiereguiluz added this to the5.0 milestone

Jan 2, 2020

javiereguiluz added a commit that referenced this pull request

Jan 2, 2020

minor#12876[String] Replace codePoint by codePointsAt (fancyweb)

b54a118

This PR was merged into the 5.0 branch.Discussion----------[String] Replace codePoint by codePointsAtsymfony/symfony#33940 renamed the `codePoint` method to `codePointsAt`.Commits-------d507793 [String] Replace codePoint by codePointsAt

javiereguiluz merged commitd507793 intosymfony:5.0

Jan 2, 2020

Copy link

Member

javiereguiluz commentedJan 2, 2020

Good catch! Thanks Thomas! I've tweaked this a bit while merging to update the associated comment and mention that the returned value is an array. Thanks.