Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] added alpha3 option to country constraint#12857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@maxperrimond
Copy link
Contributor

Documentation part ofsymfony/symfony#35116

@maxperrimondmaxperrimondforce-pushed theadded-alpha3-country-constraint branch frombf65a90 to912a217CompareJanuary 6, 2020 01:40
Applies to:ref:`property or method<validation-property-target>`
Options - `groups`_
- `message`_
- `alpha3`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should keep an alpha order here

fabpot added a commit to symfony/symfony that referenced this pull requestJan 31, 2020
…axperrimond)This PR was squashed before being merged into the 5.1-dev branch (closes#35116).Discussion----------[Validator] Add alpha3 option to country constraint| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |symfony/symfony-docs#12857A following of#33791 and#32988 to add `alpha3` option also to `Country` constraint in the validator component.Commits-------d6f34a5 [Validator] Add alpha3 option to country constraint
@wouterjwouterj removed the Waiting Code MergeDocs for features pending to be merged labelFeb 9, 2020
wouterj added a commit that referenced this pull requestFeb 9, 2020
…(maxperrimond)This PR was merged into the master branch.Discussion----------[Validator] added alpha3 option to country constraint<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/roadmap for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `master` for features of unreleased versions).-->Documentation part ofsymfony/symfony#35116Commits-------912a217 [Validator] added alpha3 option to country constraint
@wouterjwouterj merged commit912a217 intosymfony:masterFeb 9, 2020
@wouterj
Copy link
Member

Thanks for also taking care of the docs,@maxperrimond! Congratz on getting this merged in Symfony 5.1.

Fyi, I've applied@HeahDude's comment and added a directive indicating this feature is new ind0e01b6.

maxperrimond reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhAwaiting requested review from xabbuh

3 more reviewers

@HeahDudeHeahDudeHeahDude left review comments

@noniagriconomienoniagriconomienoniagriconomie left review comments

@mazuxmazuxmazux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

7 participants

@maxperrimond@wouterj@HeahDude@noniagriconomie@mazux@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp