Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
It's needed to change the returned string in testControllerResponse#12798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedDec 11, 2019
@demyanovs thanks for this contribution. I haven't run the code shown on this page ... but the whole test code looks correct to me because of this:
Do you have the exact same code as in this test and the result is different? Thanks. |
demyanovs commentedDec 11, 2019
@javiereguiluz thanks for the response. |
OskarStark commentedDec 12, 2019
That looks indeed like a bug, thank you both for sharing the very helpful screenshots 👍🏻🙂 |
javiereguiluz commentedJan 2, 2020
My mistake was that I was looking at 3.4 branch ... and this apparently changed in 4.3. So, we're merging it in 4.3 (and 4.4., 5.0 and master). Thanks@demyanovs. |
Following the documentation, we check the Calendar application and get the string "Yep, this is a leap year!" instead of "Hello Fabien".
…lerResponse (demyanovs)This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes#12798).Discussion----------It's needed to change the returned string in testControllerResponseFollowing the documentation, we check the Calendar application and get the string "Yep, this is a leap year!" instead of "Hello Fabien".<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/roadmap for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `master` for features of unreleased versions).-->Commits-------8f96598 It's needed to change the returned string
Following the documentation, we check the Calendar application and get the string "Yep, this is a leap year!" instead of "Hello Fabien".