Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[DependencyInjection] Bind tagged services#12741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…allowed in 'bind' tag (tienvx)This PR was merged into the 4.4 branch.Discussion----------[DependencyInjection][Xml] Fix the attribute 'tag' is not allowed in 'bind' tag| Q | A| ------------- | ---| Branch? | 4.4 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | N/A <!-- prefix each issue number with "Fix #", if any -->| License | MIT| Doc PR |symfony/symfony-docs/pull/12741 <!-- required for new features -->Add test case forhttps://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-services and fix a bug with attribute 'tag' is not allowedCommits-------e38f7d4 [DependencyInjection][Xml] Fix the attribute 'tag' is not allowed in 'bind' tag
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for this contribution! It's really nice, but it's missing a little detail: we need to add aversionadded directive to tell readers that this was added in Symfony 4.4.
So, please, update your pull request as follows: in line 742, just before the paragraph that starts with"By putting the bind key under _defaults ...", add the following:
..versionadded::4.4 The feature to bind tagged services was introduced in Symfony 4.4.
OskarStark commentedDec 2, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks@tienvx for working on this feature, this is much appreciated. I added the versionadded directive for you 😃 |
This PR was merged into the 4.4 branch.Discussion----------[DependencyInjection] Bind tagged servicesUpdate documentation forhttps://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-servicesNOTE: this documentation requiresymfony/symfony#34732 to be mergedCommits-------7ec6d9d [DependencyInjection] Bind tagged services
tienvx commentedDec 2, 2019
That's quick :D Thanks very much! |
OskarStark commentedDec 2, 2019
Thankyou for this contribution 🎉 |
* 4.4: Update parent_services.rst add versionadded directive. refssymfony#12741 Added article on password migrations [DependencyInjection] Bind tagged services Fix documentation for PhpUnitBridge regex configuration
Update documentation forhttps://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-services
NOTE: this documentation requiresymfony/symfony#34732 to be merged