Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[minor] remove usage of Kernel::$rootDir from docs#12719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR was submitted for the 5.0 branch but it was merged into the 4.3 branch instead (closessymfony#12707).Discussion----------uppercaseCommits-------6ba282e uppercase
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice catch! Thanks.
Uh oh!
There was an error while loading.Please reload this page.
…(jzawadzki)This PR was submitted for the 5.0 branch but it was merged into the 4.3 branch instead (closessymfony#12720).Discussion----------Changed names of Intl classes in form types docsAs persymfony/symfony#28846 we changed Intl classes to be more specific. Looks like some docs left with old naming.Commits-------f5f64e1 Changed names of Intl classes in form types docs
wouterj left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great catch!
As this method is already available in 4.x, let's merge this into 4.3. You don't have to do anything for this (our merge tool can take care of it).
* upstream/4.3: Changed names of Intl classes in form types docs uppercase
javiereguiluz commentedNov 30, 2019
Thanks! (merged in 4.3) |
…adzki)This PR was submitted for the 5.0 branch but it was squashed and merged into the 4.3 branch instead (closes#12719).Discussion----------[minor] remove usage of Kernel::$rootDir from docsAs persymfony/symfony#28810 $rootDir has been removed in 5.0 - use getProjectDir in docs instead - small change to be consistentCommits-------9da96e1 [minor] remove usage of Kernel::$rootDir from docs
As persymfony/symfony#28810 $rootDir has been removed in 5.0 - use getProjectDir in docs instead - small change to be consistent