Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
fix BrowserKit Client to AbstractBrowser rename#12717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
OskarStark commentedNov 29, 2019
I propose to add this change to |
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
OskarStark commentedNov 30, 2019
Could you add the deprecated directive@jzawadzki and change the base branch to 4.3? |
jzawadzki commentedDec 3, 2019
will do today |
HeahDude commentedFeb 7, 2020
Hello@jzawadzki are you still willing to work on this PR? Thanks! |
…bstractBrowser since SF 4.3 (Calex92)This PR was merged into the 4.4 branch.Discussion----------[Browserkit] The Client class has been replaced by the AbstractBrowser since SF 4.3I noticed that in the BrowserKit documentation, there was multiple references to the old ``Symfony\Component\BrowserKit\Client`` class instead of the ``Symfony\Component\BrowserKit\AbstractBrowser`` one.See [https://github.com/symfony/symfony/pull/30541](https://github.com/symfony/symfony/pull/30541)There was a previous merge request for SF5 here (#12717), but I don't know if it was possible for me to use it since I'm quite new with Github best practice about contribution.Don't hesitate to tell me if I'm wrong!Commits-------a3ff4e0 The Client class has been replaced by the AbstractBrowser since SF 4.3
javiereguiluz commentedJun 8, 2020
@jzawadzki thanks for contributing these fixes. Sadly we received another pull request targeted at an earlier branch, which allowed us to add the "deprecated" directive (see#13550). So, we're closing this in favor of the other one. @OskarStark we added the deprecated directive while merging and removed it in 5.0 and up. |
Uh oh!
There was an error while loading.Please reload this page.
As persymfony/symfony#30541
Clienthas been renamed toAbstractBrowser. Looks like docs were not updated