Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix BrowserKit Client to AbstractBrowser rename#12717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@jzawadzki
Copy link
Contributor

@jzawadzkijzawadzki commentedNov 27, 2019
edited
Loading

As persymfony/symfony#30541Client has been renamed toAbstractBrowser. Looks like docs were not updated

@OskarStark
Copy link
Contributor

I propose to add this change to4.3 + adding adeprecated directive, and remove this directive in 5.0

@OskarStarkOskarStark added this to the4.3 milestoneNov 29, 2019
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
@OskarStark
Copy link
Contributor

Could you add the deprecated directive@jzawadzki and change the base branch to 4.3?

@jzawadzki
Copy link
ContributorAuthor

will do today
JZ

OskarStark reacted with thumbs up emoji

@HeahDude
Copy link
Contributor

Hello@jzawadzki are you still willing to work on this PR? Thanks!

@HeahDudeHeahDude modified the milestones:4.3,4.4Feb 19, 2020
javiereguiluz added a commit that referenced this pull requestJun 8, 2020
…bstractBrowser since SF 4.3 (Calex92)This PR was merged into the 4.4 branch.Discussion----------[Browserkit] The Client class has been replaced by the AbstractBrowser since SF 4.3I noticed that in the BrowserKit documentation, there was multiple references to the old ``Symfony\Component\BrowserKit\Client`` class instead of the ``Symfony\Component\BrowserKit\AbstractBrowser`` one.See [https://github.com/symfony/symfony/pull/30541](https://github.com/symfony/symfony/pull/30541)There was a previous merge request for SF5 here (#12717), but I don't know if it was possible for me to use it since I'm quite new with Github best practice about contribution.Don't hesitate to tell me if I'm wrong!Commits-------a3ff4e0 The Client class has been replaced by the AbstractBrowser since SF 4.3
@javiereguiluz
Copy link
Member

@jzawadzki thanks for contributing these fixes. Sadly we received another pull request targeted at an earlier branch, which allowed us to add the "deprecated" directive (see#13550). So, we're closing this in favor of the other one.

@OskarStark we added the deprecated directive while merging and removed it in 5.0 and up.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@jzawadzki@OskarStark@HeahDude@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp