Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Tweak the IsTrue validation docs#12712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@javiereguiluz
Copy link
Member

Please review that this is correct:IsTrue requires that method names start with "is" or "get" Thanks!

If the ``isTokenValid()`` returns false, the validation will fail.
If the ``isTokenValid()`` returns false, the validation will fail. When applied
to methods, this constraint requires method names to start with ``is`` or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This does not look right to me. Is this based on some bug report?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The original doc said that this works with"a "getter" method" But what's that? Only getters? Because I know that it works for issers too ... so, getters + issers only? Or does this work with ANY kind of method regardless of its name? Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This works with an method that returns a boolean value.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for clarifying this. I've updated the description.

javiereguiluz added a commit that referenced this pull requestNov 30, 2019
This PR was squashed before being merged into the 3.4 branch (closes#12712).Discussion----------Tweak the IsTrue validation docsPlease review that this is correct: *IsTrue requires that method names start with "is" or "get"* Thanks!Commits-------c47d8ae Tweak the IsTrue validation docs
@javiereguiluzjaviereguiluz merged commitc47d8ae intosymfony:3.4Nov 30, 2019
@javiereguiluzjaviereguiluz deleted the is_true_constraint branchNovember 30, 2019 16:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@javiereguiluz@OskarStark@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp