Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Set PHP Version requirement to 7.2.5#12693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:5.0fromHLeithner:patch-1
Nov 30, 2019

Conversation

@HLeithner
Copy link
Contributor

Based on the last pull request for 5.0 the minimum PHP Version is 7.2.5
symfony/symfony#34443

That's also the required version in composer.json
https://github.com/symfony/symfony/blob/5.0/composer.json#L19

@javiereguiluzjaviereguiluz added Status: Reviewed Waiting Code MergeDocs for features pending to be merged and removed Status: Needs Review labelsNov 26, 2019
@javiereguiluzjaviereguiluz added this to the5.0 milestoneNov 26, 2019
@javiereguiluzjaviereguiluz added On hold and removed Waiting Code MergeDocs for features pending to be merged labelsNov 26, 2019
@javiereguiluz
Copy link
Member

@HLeithner you are right! However, the new patch versions of contracts haven't been released yet, so 7.2.9 is still the required version. I've put this "On Hold" until they are released, which hopefully will be very soon.

Thanks and congrats on your first Symfony Docs contribution!

@javiereguiluz
Copy link
Member

Translation contracts 2.0.1 has just been released (https://github.com/symfony/translation-contracts/releases) so this can be merged because PHP 7.2.5 is again the minimum required version of Symfony.

@javiereguiluz
Copy link
Member

Thanks Harald.

javiereguiluz added a commit that referenced this pull requestNov 30, 2019
This PR was merged into the 5.0 branch.Discussion----------Set PHP Version requirement to 7.2.5Based on the last pull request for 5.0 the minimum PHP Version is 7.2.5symfony/symfony#34443That's also the required version in composer.jsonhttps://github.com/symfony/symfony/blob/5.0/composer.json#L19Commits-------3d50d78 Set PHP Version requirement to 7.2.5
@javiereguiluzjaviereguiluz merged commit3d50d78 intosymfony:5.0Nov 30, 2019
@HLeithner
Copy link
ContributorAuthor

Thanks for merging. Finally we at Joomla set our minimum php version joomla 4 to version 7.2.5 too.

@javiereguiluzjaviereguiluz mentioned this pull requestDec 4, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@derrabusderrabusderrabus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

6 participants

@HLeithner@javiereguiluz@OskarStark@derrabus@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp