symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.2k
Star2.3k

[FrameworkBundle] MicroKernelTrait configureRouting(Configurator)#12688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

vudaltsov wants to merge2 commits intosymfony:masterfromvudaltsov:deprecate-route-collection-builder

Closed

[FrameworkBundle] MicroKernelTrait configureRouting(Configurator)#12688

vudaltsov wants to merge2 commits intosymfony:masterfromvudaltsov:deprecate-route-collection-builder

Conversation

Copy link

Contributor

vudaltsov commentedNov 24, 2019

symfony/symfony#32937

Updated docs referencing MicroKernelTrait::configureRoutes()

d57ab11

carsonbot added Status: Needs Review Routing labels

Nov 24, 2019

vudaltsov changed the title~~[Routing] MicroKernelTrait::configureRoutes(Builder) -> configureRouting(Configurator)~~[FrameworkBundle] MicroKernelTrait configureRouting(Configurator)

Nov 24, 2019

This was referencedNov 24, 2019

[FrameworkBundle] MicroKernelTrait configureRouting(Configurator)symfony/recipes#690

Merged

[Routing] Deprecate RouteCollectionBuildersymfony/symfony#32937

Merged

wouterj added the Waiting Code MergeDocs for features pending to be merged label

Nov 24, 2019

wouterj added this to thenext milestone

Nov 24, 2019

wouterj requested changes

Nov 24, 2019

View reviewed changes

Copy link

Member

wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for submitting the docs for your code feature! I would like to add 2 versionadded indications (it doesn't look relevant for me to put one in the 3rd file)

configuration/front_controllers_and_kernel.rstShow resolvedHide resolved

configuration/micro_kernel_trait.rstShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Nov 24, 2019

Added versionadded paragraphs

14ee1f9

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Nov 25, 2019

fabpot added a commit to symfony/symfony that referenced this pull request

Nov 25, 2019

feature#32937[Routing] Deprecate RouteCollectionBuilder (vudaltsov)

7719fc7

This PR was squashed before being merged into the 5.1-dev branch (closes#32937).Discussion----------[Routing] Deprecate RouteCollectionBuilder| Q             | A| ------------- | ---| Branch?       | 5.1| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#32240| License       | MIT| Doc PR        |symfony/symfony-docs#12688| Recipe PR |symfony/recipes#690A lot to be done here after the implementation is accepted:- [x] finish deprecations in the MicroKernelTrait- [x] deprecate the class- [x] mention in the CHANGELOG file- [x] mention in the UPGRADE file- [x] mark tests as legacy- [x] add a doc PR- [x] update the recipePing@Tobion ,@nicolas-grekas .Commits-------e641cbd [Routing] Deprecate RouteCollectionBuilder

symfony-splitter pushed a commit to symfony/routing that referenced this pull request

Nov 25, 2019

feature #32937 [Routing] Deprecate RouteCollectionBuilder (vudaltsov)

1cb3445

This PR was squashed before being merged into the 5.1-dev branch (closes #32937).Discussion----------[Routing] Deprecate RouteCollectionBuilder| Q             | A| ------------- | ---| Branch?       | 5.1| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets | #32240| License       | MIT| Doc PR        |symfony/symfony-docs#12688| Recipe PR |symfony/recipes#690A lot to be done here after the implementation is accepted:- [x] finish deprecations in the MicroKernelTrait- [x] deprecate the class- [x] mention in the CHANGELOG file- [x] mention in the UPGRADE file- [x] mark tests as legacy- [x] add a doc PR- [x] update the recipePing@Tobion ,@nicolas-grekas .Commits-------e641cbdd46 [Routing] Deprecate RouteCollectionBuilder

symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request

Nov 25, 2019

feature #32937 [Routing] Deprecate RouteCollectionBuilder (vudaltsov)

58f11c0

This PR was squashed before being merged into the 5.1-dev branch (closes #32937).Discussion----------[Routing] Deprecate RouteCollectionBuilder| Q             | A| ------------- | ---| Branch?       | 5.1| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets | #32240| License       | MIT| Doc PR        |symfony/symfony-docs#12688| Recipe PR |symfony/recipes#690A lot to be done here after the implementation is accepted:- [x] finish deprecations in the MicroKernelTrait- [x] deprecate the class- [x] mention in the CHANGELOG file- [x] mention in the UPGRADE file- [x] mark tests as legacy- [x] add a doc PR- [x] update the recipePing@Tobion ,@nicolas-grekas .Commits-------e641cbdd46 [Routing] Deprecate RouteCollectionBuilder

javiereguiluz removed the Waiting Code MergeDocs for features pending to be merged label

Sep 7, 2020

Copy link

Member

wouterj commentedOct 21, 2020

Hi@vudaltsov! Thanks for submitting a doc PR alonside your code one.

However, when looking at the current code, it seems like the route is still calledconfigureRoutes():https://github.com/symfony/symfony/blob/5.1/src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.php#L159-L163 So I'm going to close this PR, as it seems like there is nothing more to do (the micro kernel example has recently been updated to use the configurators).

If I'm wrong, feel free to comment :)