Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Add container.hot_path to built-in service tags#12684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@glickel very nice contribution about something important which was missing in the docs. I left some minor comments. Congrats on your first Symfony Docs contribution!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
glickel commentedNov 26, 2019
@javiereguiluz thank you for your comment and feedbacks, normally all issues should be fixed. I should check twice before pushing :) |
Uh oh!
There was an error while loading.Please reload this page.
OskarStark commentedNov 26, 2019
Thanks Gaetan for working on this feature, this is much appreciated. |
This PR was merged into the 3.4 branch.Discussion----------Add container.hot_path to built-in service tagsRelated to [symfony/symfony#24872](symfony/symfony#24872)<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/roadmap for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `master` for features of unreleased versions).-->Commits-------1647b9a Add container.hot_path to built-in service tags
Related tosymfony/symfony#24872