@nicolas-grekas the full API is very long because there are a ton of methods ... so I thought about grouping them by "topic". Would you agree with that?

Thanks!

carsonbot added the Status: Needs Review label

Oct 7, 2019

javiereguiluz added the String label

Oct 7, 2019

javiereguiluz added this to the5.0 milestone

Oct 7, 2019

Copy link

Member

nicolas-grekas commentedOct 7, 2019

Works for me, thank you.

Copy link

Contributor

OskarStark commentedOct 8, 2019

Great work so far Javier 🙂👍🏻

Copy link

MemberAuthor

javiereguiluz commentedOct 8, 2019

The article is now ready for review. The only missing part is the Slugger, which I'll add soon too. Thanks.

nicolas-grekas reviewed

Oct 8, 2019

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's cool thank you :)
Here are some comments.

components/string.rstShow resolvedHide resolved

components/string.rst OutdatedShow resolvedHide resolved

components/string.rstShow resolvedHide resolved

components/string.rst OutdatedShow resolvedHide resolved

components/string.rstShow resolvedHide resolved

components/string.rst OutdatedShow resolvedHide resolved

nicolas-grekas mentioned this pull request

Oct 8, 2019

[String] add $lastGlue argument to join() methodssymfony/symfony#33914

Merged

This was referencedOct 9, 2019

[String] Add tests for replaceMatches()symfony/symfony#33905

Closed

[String] Should UnicodeString return all code points for a given grapheme?symfony/symfony#33923

Closed

javiereguiluz changed the title~~(WIP) Documented the String component~~Documented the String component

Oct 9, 2019

OskarStark approved these changes

Oct 9, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Oct 9, 2019

gharlan mentioned this pull request

Oct 9, 2019

[String] bytesAt() and codePointsAt()symfony/symfony#33940

Merged

gharlan reviewed

Oct 9, 2019

View reviewed changes

components/string.rstShow resolvedHide resolved

components/string.rst OutdatedShow resolvedHide resolved

components/string.rstShow resolvedHide resolved

components/string.rst OutdatedShow resolvedHide resolved

nicolas-grekas added a commit to symfony/symfony that referenced this pull request

Oct 11, 2019

minor#33914[String] add $lastGlue argument to join() methods (nicol…

90ca602

…as-grekas)This PR was merged into the 5.0-dev branch.Discussion----------[String] add $lastGlue argument to join() methods| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -An idea that came when reviewingsymfony/symfony-docs#12440Commits-------714d629 [String] add $lastGlue argument to join() methods

gharlan mentioned this pull request

Oct 13, 2019

[String] wrap(): test and fixsymfony/symfony#33970

Merged

Documented the String component

9d08de4

javiereguiluz force-pushed thefix_12376 branch from84bd97d to9d08de4Compare

October 14, 2019 08:35

javiereguiluz merged commit9d08de4 intosymfony:master

Oct 14, 2019

javiereguiluz deleted the fix_12376 branch

October 14, 2019 08:36

javiereguiluz mentioned this pull request

Oct 14, 2019

[String] Introduce a locale-aware Slugger in the String component#12404

Closed

nicolas-grekas added a commit to symfony/symfony that referenced this pull request

Oct 14, 2019

bug#33970[String] wrap(): test and fix (gharlan)

9d9d095

This PR was merged into the 5.0-dev branch.Discussion----------[String] wrap(): test and fix| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | n/a| License       | MIT| Doc PR        |symfony/symfony-docs/pull/12440Commits-------015b81a [String] wrap(): test and fix

symfony-splitter pushed a commit to symfony/string that referenced this pull request

Oct 14, 2019

bug #33970 [String] wrap(): test and fix (gharlan)

83d76db

This PR was merged into the 5.0-dev branch.Discussion----------[String] wrap(): test and fix| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | n/a| License       | MIT| Doc PR        |symfony/symfony-docs/pull/12440Commits-------015b81a2f5 [String] wrap(): test and fix

nicolas-grekas added a commit to symfony/symfony that referenced this pull request

Oct 14, 2019

bug#33940[String] bytesAt() and codePointsAt() (gharlan)

5880c5c

This PR was merged into the 5.0-dev branch.Discussion----------[String] bytesAt() and codePointsAt()| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       |Fix#33923| License       | MIT| Doc PR        |symfony/symfony-docs/pull/12440Commits-------f8d2faa [String] bytesAt() and codePointsAt()