Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Added Unicode information about routes#1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dlsniper commentedApr 18, 2012
As far as I could tell, the unicode support was added already by other changes in the routing component and the original PR insymfony/symfony#3629 is now updated just to include those tests. Imho this could be merged regardless of the original PR but imho it would be nice to also have that merged as well... Kind regards. |
Added Unicode information about routes
weaverryan commentedApr 21, 2012
I've merged in the PR as it appears that unicode is supported now even without your PR. But if I'm mistaken, please let me know! Thanks! |
dlsniper commentedApr 30, 2012
@weaverryan It seems I was a bit wrong about the Unicode support. While Symfony2.1 will bring some unicode support it will not befull support. So maybe we should revert this someone. Should I submit a PR to correct this? Kind regards. |
When/ifsymfony/symfony#3629 will be merged then this should be merged as well as it documents the change.
Thanks.