Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Documenting ErrorRenderer and ErrorHandler components#12187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
5a0d170 to2c78789Compare8123fd8 to5136a17Compare
OskarStark left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great work 👍🏻
Uh oh!
There was an error while loading.Please reload this page.
maxhelias commentedAug 17, 2019
It's targeted master, it's should be on 4.4 ? |
OskarStark commentedAug 17, 2019
Yes 4.4 👍🏻 |
| available, the handler uses a Symfony Response object; if not, it falls | ||
| back to a regular PHP response. | ||
| Catches PHP errors and turn them into exceptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
btw, documentingsymfony/symfony#33155, close#12193
OskarStark commentedAug 20, 2019
@wouterj could you please leave some feedback here? Thanks. |
javiereguiluz commentedSep 19, 2019
I have some proposals to reword some things and to change some sections ... but I prefer to do that in a separate PR to allow others to review the proposed changes. That's why I'm merging this "as is". Yonel, thanks a lot for such a nice contribution! |
…aviereguiluz, yceruto)This PR was merged into the 4.4 branch.Discussion----------Documenting ErrorRenderer and ErrorHandler componentsReplace#11864Closes#12193#12009#11980#12015#12019#12029Should we remove the whole Debug component documentation? or remove only the details and say it's deprecated?Commits-------8cc084f documenting the ErrorHandler::call method3ea9817 fix service definition5a025c9 fix example5136a17 Update with latest changes: ErrorRenderer and ErrorHandler componentsb0723ef Fixed a method nameb600b3c Renamed ErrorCatcher as ErrorRenderer4e333c1 Fixesb2a1a9b Documented the ErrorCatcher component
…onents (javiereguiluz)This PR was squashed before being merged into the 4.4 branch (closes#12344).Discussion----------Some rewords for the ErrorHandler and ErrorRenderer componentsThis continues#12187 with some rewords.Commits-------6220b48 Some rewords for the ErrorHandler and ErrorRenderer components
Uh oh!
There was an error while loading.Please reload this page.
Replace#11864
Closes#12193#12009#11980#12015#12019#12029
Should we remove the whole Debug component documentation? or remove only the details and say it's deprecated?