Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rewrite Intl introduction#12174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:4.3fromterjebraten-certua:intl-intro
Aug 15, 2019

Conversation

@terjebraten-certua
Copy link
Contributor

@terjebraten-certuaterjebraten-certua commentedAug 15, 2019
edited
Loading

When I first looked at the documentation for the Intl component, I thought I was looking at the wrong place. I got the first impression that this was only about a PHP replacement layer for the C intl extension, and that was not what I was looking for.

This PR is about replacing the introduction paragraph at the top to make it clear that this component may be useful to you even if you do not need the replacement layer and have the PHP intl extension installed.

@OskarStark
Copy link
Contributor

@ro0NL could you please verify this? Thank you

Also this must go into4.3 if I am right.

@ro0NL
Copy link
Contributor

i tend to agreeAccessing ICU Data is the first concern of the Intl component, today. Or put different the idea of stubbing is you dont actually notice it's stubbed, so it seems less important

It was much worse before though :)#11590

@terjebraten-certuaterjebraten-certua changed the base branch from4.4 to4.3August 15, 2019 10:13
@OskarStarkOskarStark added this to the4.3 milestoneAug 15, 2019
@OskarStark
Copy link
Contributor

Thank you Terje.

@OskarStarkOskarStark merged commit83aa6f7 intosymfony:4.3Aug 15, 2019
OskarStark added a commit that referenced this pull requestAug 15, 2019
This PR was merged into the 4.3 branch.Discussion----------Rewrite Intl introductionWhen I first looked at the documentation for the Intl component, I thought I was looking at the wrong place. I got the first impression that this was only about a PHP replacement layer for the C intl extension, and that was not what I was looking for.This PR is about replacing the introduction paragraph at the top to make it clear that this component may be useful to you even if you do not need the replacement layer and have the PHP intl extension installed.Commits-------83aa6f7 Rewrite Intl introduction
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

+1 more reviewer

@ro0NLro0NLro0NL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@terjebraten-certua@OskarStark@ro0NL@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp