Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[4.3] Update workflow config#12146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR was merged into the 4.3 branch.Discussion----------[4.3] Update workflow configRescued some really bad git stuff from me while merging:#11580Original description:> Hi,>> This draft PR follows this one>https://github.com/symfony/symfony-docs/pull/11492/files (config for 3.X version)> but for new version, mostly 4.3>> I checked this PR also>symfony/symfony#30890,@lyrixx review appreciated please>> Maybe to merge after merging#11578, and with a rebase ?>> -------------------->> Draft for now>> -Closes#11229>> this one can be closed also:>> -Closes#9475> -Closes#10197Commits-------fdc221b Minor XML improvementa640d14 [Workflow] config doc7bb2041 Fix indentf65f1bc Reviewcf3a32c Doc config metadata34e7cc5 [Workflow] config doc
| When you have configured a ``Registry`` with your workflows, | ||
| you canretrieve a workflow from it and use it as follows:: | ||
| you canretreive a workflow from it and use it as follows:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It looks likeretrieve is the right orthography.
| // ... | ||
| // Consider that $blogPost is in place "draft" by default | ||
| // Consider that $post is in state "draft" by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The variable$post doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes i updated it in another PR, and on the original one i added this line
which then create a fail merge :/
OskarStark commentedAug 13, 2019
Would you send a PR? |
* 4.3: Added the LICENSE file Added the Code of Conduct file [symfony#12146] fix typos
* 4.4: Added the LICENSE file Added the Code of Conduct file [symfony#12146] fix typos
Rescued some really bad git stuff from me while merging:#11580
Original description: