Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update expressions.rst#12132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:3.4fromkevinreniers:patch-1
Aug 15, 2019
Merged

Update expressions.rst#12132

OskarStark merged 1 commit intosymfony:3.4fromkevinreniers:patch-1
Aug 15, 2019

Conversation

kevinreniers
Copy link
Contributor

@kevinrenierskevinreniers commentedAug 9, 2019
edited
Loading

Clarify the difference between theis_anonymous function andIS_AUTHENTICATED_ANONYMOUSLY.
Thisfixes#11950.

@@ -56,7 +56,9 @@ Additionally, you have access to a number of functions inside the expression:
Returns ``true`` if the user is authenticated via "remember-me" or authenticated
"fully" - i.e. returns true if the user is "logged in".
``is_anonymous``
Equal to using ``IS_AUTHENTICATED_ANONYMOUSLY`` with the ``isGranted()`` function.
Returns ``true`` if the user is anonymous. That is, the firewall confirms that it
does not know this user's identity. This is different from ``IS_AUTHENTICATED_ANONYMOUSLY``,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about renaming it to „IS_AUTHENTICATED_OR_ANONYMOUSLY“ to make it more clear and understandable?

cc@chalasr

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sure, but that seems like a topic for its own PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Absolutely this must be implemented int the code base first 👌🏻

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OskarStark reacted with thumbs up emoji
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@chalasr 👍

Could you approve this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's not ready yet! This PR is correct for lower versions anyways

OskarStark reacted with thumbs up emoji
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should apply on 3.4 if I'm not mistaken

OskarStark reacted with thumbs up emoji
Clarify the difference between the `is_anonymous` function and `IS_AUTHENTICATED_ANONYMOUSLY`.
@OskarStarkOskarStark changed the base branch from4.3 to3.4August 15, 2019 04:36
@OskarStark
Copy link
Contributor

Thank you Kevin.

kevinreniers reacted with hooray emoji

@OskarStarkOskarStark merged commit6df9898 intosymfony:3.4Aug 15, 2019
OskarStark added a commit that referenced this pull requestAug 15, 2019
This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes#12132).Discussion----------Update expressions.rstClarify the difference between the `is_anonymous` function and `IS_AUTHENTICATED_ANONYMOUSLY`.Thisfixes#11950.Commits-------6df9898 Update expressions.rst
@kevinrenierskevinreniers deleted the patch-1 branchAugust 15, 2019 09:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@chalasrchalasrchalasr approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

4 participants
@kevinreniers@OskarStark@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp