symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

Doctrine Section -- Change CodeBlock terminal to CodeBlock console#12060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

TheGarious wants to merge1 commit intosymfony:4.3fromTheGarious:patch-3

Closed

Doctrine Section -- Change CodeBlock terminal to CodeBlock console#12060

TheGarious wants to merge1 commit intosymfony:4.3fromTheGarious:patch-3

Conversation

Copy link

Contributor

TheGarious commentedJul 30, 2019

In Symfony Docs if you use code block terminal the text color change "New property name (press " is different to "to stop adding fields):"

Example :https://symfony.com/doc/current/doctrine.html#creating-an-entity-class

With code block console this color difference is not applied.

Change terminal for console

9db8705

In Symfony Docs if you use code block terminal the text color change  "New property name (press <return>" is different to "to stop adding fields):" Example :https://symfony.com/doc/current/doctrine.html#creating-an-entity-classWith code block console this color difference is not applied.

carsonbot added the Status: Needs Review label

Jul 30, 2019

TheGarious changed the title~~Change terminal for console~~Change CodeBlock terminal to CodeBlock console

Jul 30, 2019

TheGarious changed the title~~Change CodeBlock terminal to CodeBlock console~~Doctrine Section -- Change CodeBlock terminal to CodeBlock console

Jul 30, 2019

OskarStark requested a review fromjaviereguiluz

July 31, 2019 06:35

OskarStark added the Doctrine label

Jul 31, 2019

OskarStark added this to the4.3 milestone

Jul 31, 2019

javiereguiluz mentioned this pull request

Jul 31, 2019

Updated the lexer used to highlight terminal blocks#12067

Merged

Copy link

Member

javiereguiluz commentedJul 31, 2019

Gary, thanks for reporting this problem. Sadly this is not the only place where this kind of errors happen. The real problem is the "lexer" we use to detect "console prompts". We're trying to fix this in#12067.

Copy link

ContributorAuthor

TheGarious commentedJul 31, 2019

Ok, but i change in few page this code block terminal with code block console.

Copy link

Member

javiereguiluz commentedJul 31, 2019

I'm not sure, but I thinkterminal andconsole are treated the same.bash is similar but different (we usebash for.env files because they shouldn't be displayed inside a terminal).

Copy link

ContributorAuthor

TheGarious commentedJul 31, 2019

When i use CodeBlock Console i don't have this problem of CodeBlock Terminal.

Copy link

Member

javiereguiluz commentedJul 31, 2019

Yes, I just saw the difference. Both look the same ... except precisely for the prompt. "terminal" highlights prompts to make them unselectable, whereas "console" doesn't do that. We strongly prefer to useterminal because of that behavior (people in the community asked us to make prompts not selectable to simplify copy+pasting code). So, let's wait and see if#12067 fixes the problem. Thanks.