Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Bundles] Documented the getPublicDir() method#11930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
maxhelias approved these changesJul 10, 2019
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestJul 12, 2019
…ereguiluz)This PR was squashed before being merged into the 4.4 branch (closes #32452).Discussion----------[Bundles] Rename getPublicPath() as getPublicDir()| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | -| License | MIT| Doc PR | I'll add this if approvedWhile documenting #31975 (seesymfony/symfony-docs#11930) I realized that the `getPublicPath()` method name is not consistent with the rest of Symfony.In Symfony, "path" is usually associated to routes and we use "dir" for things similar to this:* `getCacheDir()` and `getLogdir()` to override Symfony structure (https://symfony.com/doc/current/configuration/override_dir_structure.html)* `binDir`, `configDir`, `srcDir`, `varDir`, `publicDir` in Symfony Flex recipes (https://github.com/symfony/recipes) to override the dir structureSo, this PR proposes to rename `getPublicPath()` as `getPublicDir()`Commits-------4ab2f9955b [Bundles] Rename getPublicPath() as getPublicDir()
fabpot added a commit to symfony/symfony that referenced this pull requestJul 12, 2019
…ereguiluz)This PR was squashed before being merged into the 4.4 branch (closes#32452).Discussion----------[Bundles] Rename getPublicPath() as getPublicDir()| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | -| License | MIT| Doc PR | I'll add this if approvedWhile documenting#31975 (seesymfony/symfony-docs#11930) I realized that the `getPublicPath()` method name is not consistent with the rest of Symfony.In Symfony, "path" is usually associated to routes and we use "dir" for things similar to this:* `getCacheDir()` and `getLogdir()` to override Symfony structure (https://symfony.com/doc/current/configuration/override_dir_structure.html)* `binDir`, `configDir`, `srcDir`, `varDir`, `publicDir` in Symfony Flex recipes (https://github.com/symfony/recipes) to override the dir structureSo, this PR proposes to rename `getPublicPath()` as `getPublicDir()`Commits-------4ab2f99 [Bundles] Rename getPublicPath() as getPublicDir()
symfony-splitter pushed a commit to symfony/http-kernel that referenced this pull requestJul 12, 2019
…ereguiluz)This PR was squashed before being merged into the 4.4 branch (closes #32452).Discussion----------[Bundles] Rename getPublicPath() as getPublicDir()| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | -| License | MIT| Doc PR | I'll add this if approvedWhile documenting #31975 (seesymfony/symfony-docs#11930) I realized that the `getPublicPath()` method name is not consistent with the rest of Symfony.In Symfony, "path" is usually associated to routes and we use "dir" for things similar to this:* `getCacheDir()` and `getLogdir()` to override Symfony structure (https://symfony.com/doc/current/configuration/override_dir_structure.html)* `binDir`, `configDir`, `srcDir`, `varDir`, `publicDir` in Symfony Flex recipes (https://github.com/symfony/recipes) to override the dir structureSo, this PR proposes to rename `getPublicPath()` as `getPublicDir()`Commits-------4ab2f99 [Bundles] Rename getPublicPath() as getPublicDir()
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#11927.