symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

Documented the ErrorRenderer component#11864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

javiereguiluz wants to merge4 commits intosymfony:4.4fromjaviereguiluz:fix_11837

Closed

Documented the ErrorRenderer component#11864

javiereguiluz wants to merge4 commits intosymfony:4.4fromjaviereguiluz:fix_11837

Conversation

Copy link

Member

javiereguiluz commentedJul 2, 2019

Thisfixes#11837.

I'll need help for some things:

I don't understand well how this component is enabled/disabled/configured both as a stand-alone component and inside a Symfony application.
I'm not sure if I removed the right things from Debug component. Should we make more changes?

Thanks.

Documented the ErrorCatcher component

67b2446

javiereguiluz added the ErrorCatcher label

Jul 2, 2019

javiereguiluz added this to the4.4 milestone

Jul 2, 2019

carsonbot added the Status: Needs Review label

Jul 2, 2019

yceruto reviewed

Jul 2, 2019

View reviewed changes

Copy link

Member

yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a quick review.

Thank you for caring about this!

components/error_catcher.rst OutdatedShow resolvedHide resolved

components/error_catcher.rstShow resolvedHide resolved

yceruto reviewed

Jul 2, 2019

View reviewed changes

components/error_catcher.rst OutdatedShow resolvedHide resolved

Fixes

7447273

ihmels reviewed

Jul 9, 2019

View reviewed changes

components/error_catcher.rst OutdatedShow resolvedHide resolved

Renamed ErrorCatcher as ErrorRenderer

e6facb4

javiereguiluz added the On hold label

Jul 12, 2019

Fixed a method name

372224b

javiereguiluz mentioned this pull request

Jul 12, 2019

Add docs for: Rename ErrorCatcher to ErrorRenderer (rendering part on..#11948

Closed

javiereguiluz changed the title~~Documented the ErrorCatcher component~~Documented the ErrorRenderer component

Jul 12, 2019

Copy link

Member

yceruto commentedJul 12, 2019

This document needs to be divided, now the ErrorRenderer component contains only the renderer layer and the new ErrorHandler component (symfony/symfony#32471) contains the handlers.

Copy link

Contributor

OskarStark commentedAug 15, 2019

@yceruto is this still necessary or can we close this PR?

Copy link

Member

yceruto commentedAug 15, 2019

I think the ErrorRenderer part is still good. I will try to update it according to the latest changes.

yceruto mentioned this pull request

Aug 16, 2019

Documenting ErrorRenderer and ErrorHandler components#12187

Merged

Copy link

Member

yceruto commentedAug 16, 2019

See#12187, Javier, feel free to continue your work there.

Copy link

MemberAuthor

javiereguiluz commentedSep 18, 2019

Let's close this in favor of#12187.

javiereguiluz closed this

Sep 18, 2019

javiereguiluz added a commit that referenced this pull request

Sep 19, 2019

minor#12187Documenting ErrorRenderer and ErrorHandler components (j…

d216423

…aviereguiluz, yceruto)This PR was merged into the 4.4 branch.Discussion----------Documenting ErrorRenderer and ErrorHandler componentsReplace#11864Closes#12193#12009#11980#12015#12019#12029Should we remove the whole Debug component documentation? or remove only the details and say it's deprecated?Commits-------8cc084f documenting the ErrorHandler::call method3ea9817 fix service definition5a025c9 fix example5136a17 Update with latest changes: ErrorRenderer and ErrorHandler componentsb0723ef Fixed a method nameb600b3c Renamed ErrorCatcher as ErrorRenderer4e333c1 Fixesb2a1a9b Documented the ErrorCatcher component