Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] improve Workflow component documentation#11835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:4.3fromnoniagriconomie:patch-4
Jul 18, 2019

Conversation

@noniagriconomie
Copy link
Contributor

@noniagriconomienoniagriconomie commentedJun 27, 2019•
edited
Loading

Hi

Here is a minor improvement of this part of the doc.

  • do not use deprecated marking store
  • use the right wording: place and transition instead of state and action
  • rewrite some vars name

Thx

@noniagriconomie
Copy link
ContributorAuthor

noniagriconomie commentedJul 4, 2019•
edited
Loading

@OskarStark any change to do?
can be merged with#11845? (2 PRs as i propose PR from sf doc page)

Also, can you take a look at#11580 ?

Many thanks

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is fine from my side.
I will have a look at the other PR 👍🏻

@OskarStark
Copy link
Contributor

@javiereguiluz is this the right target branch? 🤔

@wouterjwouterj merged commite0d6c11 intosymfony:4.3Jul 18, 2019
wouterj added a commit that referenced this pull requestJul 18, 2019
…oniagriconomie)This PR was merged into the 4.3 branch.Discussion----------[Workflow] improve Workflow component documentationHiHere is a minor improvement of this part of the doc.- do not use deprecated marking store- use the right wording: place and transition instead of state and action- rewrite some vars nameThxCommits-------e0d6c11 Update workflow.rst
@wouterj
Copy link
Member

Hi@noniagriconomie! Thanks for your PR, all changes make 100% sense to me.

@OskarStark the deprecation is done in 4.3. So I've merged it directly into 4.3 (the current target branch of this PR). No need to do complex git stuff for the other changes (most of the users will read the current version of the docs).

@noniagriconomie
Copy link
ContributorAuthor

@wouterj thanks for merging

can you please take a look to#11580 as well?
very similar: workflow config for 4.3

cheers

@noniagriconomienoniagriconomie deleted the patch-4 branchJuly 18, 2019 10:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@noniagriconomie@OskarStark@wouterj@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp