Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix new instance of a class name#11830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:3.4frompeaceant:fix_11824
Jun 27, 2019
Merged

Conversation

@peaceant
Copy link
Contributor

Fix for#11824

@OskarStark
Copy link
Contributor

OskarStark commentedJun 26, 2019•
edited
Loading

cc@Nyholm, but I think this fix is correct

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the ping.

Yes. That is correct. Thank you for improving the docs!

OskarStark reacted with thumbs up emoji
@javiereguiluzjaviereguiluz changed the base branch from4.3 to3.4June 27, 2019 06:37
@javiereguiluzjaviereguiluz merged commitc08a0e3 intosymfony:3.4Jun 27, 2019
javiereguiluz added a commit that referenced this pull requestJun 27, 2019
This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes#11830).Discussion----------Fix new instance of a class nameFix for#11824Commits-------c08a0e3 Fix new instance of a class name
@javiereguiluz
Copy link
Member

@peaceant thanks for this fix (we merged it in 3.4 branch) and congrats on your first Symfony Docs contribution!

Nyholm and peaceant reacted with hooray emoji

@Nyholm
Copy link
Member

Wohoo! =)

@Art4
Copy link
Contributor

Art4 commentedJul 24, 2019•
edited
Loading

@javiereguiluz Why have you changed the merging branch from4.3 to3.4?

There is noSymfony\Component\Cache\**Simple\Psr16Adapter**, but theSymfony\Component\Cache\**Adapter\Psr16Adapter** orSymfony\Component\Cache\**Simple\Psr6Cache**.

TheSymfony\Component\Cache\**Adapter\Psr16Adapter** was introduced in 4.3, seesymfony/symfony#29236. Hence the docs is now wrong.

class3.44.04.14.24.34.4
Symfony\Component\Cache\Adapter\Psr16Adapter❌❌❌❌✔️✔️
Symfony\Component\Cache\Simple\Psr6Cache✔️✔️✔️✔️⚠️⚠️

javiereguiluz added a commit that referenced this pull requestJul 26, 2019
This PR was merged into the 3.4 branch.Discussion----------Fix Psr6Cache classname for 3.4 and 4.2This PR will fix a wrong class name that was added in#11830.This PR affects only the branches 3.4 and 4.2.In 4.3 the class was deprecated and moved to `Symfony\Component\Cache\Psr16Cache`, so the branches 4.3 and 4.4 are not affected.Commits-------595ed5b Fix classname for Psr6Cache
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

+1 more reviewer

@NyholmNyholmNyholm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@peaceant@OskarStark@javiereguiluz@Nyholm@Art4@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp