Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Cache] Make sure the chain cache configuration works#11813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Nyholm commentedJun 24, 2019
I've updated the PR. I tested the new config and it works perfectly. |
javiereguiluz commentedJun 25, 2019
@Nyholm can you please confirm that this must go to 4.3 branch and not to 3.4 or 4.2? Thanks. |
Nyholm commentedJun 25, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sorry, no. This is equally true for 3.4. All active versions of the docs should be updated with this PR. |
javiereguiluz commentedJun 25, 2019
Thanks Tobias. |
…yholm)This PR was submitted for the 4.3 branch but it was squashed and merged into the 3.4 branch instead (closes#11813).Discussion----------[Cache] Make sure the chain cache configuration worksI just tried the configuration and noticed a few issues.~~Im not 100% sure this actually works.~~ Lets wait forsymfony/symfony#32139Im sure nowCommits-------9fbebaf [Cache] Make sure the chain cache configuration works
Nyholm commentedJun 25, 2019
Thank you for the review and thank you for merging |
…y providing several adapters (nicolas-grekas)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle] Allow creating chained cache pools by providing several adapters| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Replaces#30984, followssymfony/symfony-docs#11813This PR allows defining several adapters for one pool. When doing so, this defines a chain pool.The benefit is that all chained pools get automatic namespace and lifetime, so things are transparent:```yamlpools: my_chained_pool: default_lifetime: 12 adapters: - cache.adapter.array - cache.adapter.filesystem - {name: cache.adapter.redis, provider: 'redis://foo'}```(see fixtures for example of PHP/XML config)/cc@Nyholm@pborreli FYICommits-------29ba091 [FrameworkBundle] Allow creating chained cache pools by providing several adapters
Uh oh!
There was an error while loading.Please reload this page.
I just tried the configuration and noticed a few issues.
Im not 100% sure this actually works.Lets wait forsymfony/symfony#32139Im sure now