Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Process] allow writing "prepared" command line.#11802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| $process->run(); | ||
| Using a Prepared Command Line | ||
| -------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should the same length as the title itself to be valid
| Using a Prepared Command Line | ||
| -------------------------------- | ||
| This component also provides a way to use the process command with prepared using the double brackets notations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missing word afterwith prepared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
double bracket notation
| -------------------------------- | ||
| This component also provides a way to use the process command with prepared using the double brackets notations: | ||
| Which means that you can use placeholder in order to have a process that can be changed only with the values and without changing the php code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
use a placeholder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
PHP
…nes (Simperfit)This PR was merged into the 4.4 branch.Discussion----------[Process] Allow writing portable "prepared" command lines| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#23778 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR |symfony/symfony-docs#11802 <!-- required for new features -->Hey here, it's me, again !I've talked with@nicolas-grekas and he gave me a new way of writing this feature that will not be a problem for people using things like {{ toto }} since we are using the linux style of using envvar, the replaced arguments is only replaced when using windows.This should not break anything and work as expected!see#24763This makes `"$FOO"` work seamlessly on Linux and on Windows to reference an env var (that can be provided when calling e.g. the "run" method)Commits-------3f8354f [Process] Allow writing portable "prepared" command lines
OskarStark commentedAug 1, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@Simperfit do you find some time to finish this PR? 😃 Note for the mergers, this must go in |
Simperfit commentedAug 6, 2019
Ill do it asap ;) |
OskarStark commentedAug 15, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for your work on this new feature! Cheers 😃 |
* 4.4: Tweaks#11802 [Process] allow writing "prepared" command line.
Simperfit commentedAug 16, 2019
Thanks@OskarStark |
| Using a Prepared Command Line | ||
| -------------------------------- | ||
| This component also provides a way to use the process command with prepared using the double brackets notations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What does "double bracket notation" mean?
Uh oh!
There was an error while loading.Please reload this page.
This documents the re-pushed prepared command line with a new style of writing it that does not break anything.
symfony/symfony#32126