Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

#27345 Added Symfony\Component\Lock\Store\MongoDbStore#11735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

kralos
Copy link

@kraloskralos commentedJun 13, 2019
edited by OskarStark
Loading

Added Lock MongoDbStore documentation to symfony 5.1

@kralos
Copy link
Author

seesymfony/symfony#31889

@OskarStarkOskarStark added this to the4.4 milestoneJun 13, 2019
@OskarStarkOskarStark added Lock Waiting Code MergeDocs for features pending to be merged labelsJun 13, 2019
@kraloskralosforce-pushed the27345-added-lock-mongodb-store branch fromafab849 to02493d3CompareAugust 22, 2019 04:48
@kralos
Copy link
Author

git rebase origin/4.4 and squashed

@kraloskralosforce-pushed the27345-added-lock-mongodb-store branch from5f7b165 to13bddebCompareNovember 5, 2019 07:00
fabpot added a commit to symfony/symfony that referenced this pull requestDec 11, 2019
This PR was submitted for the 4.4 branch but it was squashed and merged into the 5.1-dev branch instead (closes#31889).Discussion----------[Lock] add mongodb store| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes (requires `ext-mongodb` and `mongodb/mongodb` to test)| Fixed tickets |#27345| License       | MIT| Original Doc PR        |symfony/symfony-docs#9807| Remove from 4.3 Doc PR |symfony/symfony-docs#11686| Add to 4.4 Doc PR |symfony/symfony-docs#11735Looks like I messed up `kralos:27345-lock-mongodb` with a force push (trying to fix ci issues) right before it was merged to `master` (`4.3.0`).see#27648**Description**We should support Semaphore Locks with a MongoDB back end to allow those that already use MongoDB as a distributed storage engine.Symfony already partially supports MongoDB for session storage: `Symfony\Component\HttpFoundation\Session\Storage\Handler\MongoDbSessionHandler`**Example**```php$client = new MongoDb\Client();$store = new Symfony\Component\Lock\Store\MongoDbStore(    $client    array(        'database' => 'my-app',    ));$lockFactory = new Symfony\Component\Lock\Factory($store);$lock = $lockFactory->createLock('my-resource');```Commits-------a6bfa59 [Lock] add mongodb store
@kraloskralosforce-pushed the27345-added-lock-mongodb-store branch fromab51419 toe8d6e49CompareDecember 11, 2019 00:50
@kralos
Copy link
Author

Since@fabpot just mergedsymfony/symfony#31889 I've re-based this fromsymfony-docs/master and bumped the introduced in version number to5.1

OskarStark reacted with thumbs up emoji

@OskarStarkOskarStark removed the Waiting Code MergeDocs for features pending to be merged labelDec 11, 2019
@OskarStarkOskarStark modified the milestones:4.4,5.1Dec 11, 2019
@kraloskralosforce-pushed the27345-added-lock-mongodb-store branch from8087cd4 to392140aCompareFebruary 16, 2020 23:02
@kraloskralos changed the base branch from4.4 to5.0February 16, 2020 23:03
@kraloskralosforce-pushed the27345-added-lock-mongodb-store branch from392140a to679a77eCompareFebruary 16, 2020 23:07
@kraloskralos changed the base branch from5.0 tomasterFebruary 16, 2020 23:07
@kralos
Copy link
Author

kralos commentedFeb 16, 2020
edited
Loading

The code for this has been merged intosymfony/symfonymastersymfony/symfony#31889. It will be released insymfony5.1. I've updated this merge request accordingly (again). Can someone please review / merge?

OskarStark reacted with thumbs up emoji

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@kralos thanks a lot for your contribution. I tried to merge it with the internal tool we use to merge Symfony PRs ... but I faced an error that I couldn't fix myself. So, could you please rebase your PR one last time? Thanks!

@kraloskralosforce-pushed the27345-added-lock-mongodb-store branch fromcc02ab4 to934401fCompareApril 11, 2020 09:24
@kralos
Copy link
Author

@javiereguiluz I've fixed the branch, also noticed the DBAL link was broken (Doctrine dropped the DBAL dir using psr-4) so i've updated it

@javiereguiluz
Copy link
Member

Merged! Thanks a lot for the extra effort needed to rebase and get this PR ready.

@javiereguiluzjaviereguiluz merged commitbe88d94 intosymfony:masterApr 11, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

@HeahDudeHeahDudeAwaiting requested review from HeahDude

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

4 participants
@kralos@javiereguiluz@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp